Title: [105401] trunk/LayoutTests
- Revision
- 105401
- Author
- zimmerm...@webkit.org
- Date
- 2012-01-19 04:17:09 -0800 (Thu, 19 Jan 2012)
Log Message
RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446
Reviewed by Pavel Feldman.
Fix Chromium specific problem with svg/text/select-x-list-4.svg, making it fail on the bots.
After transforming the endPos.x + 1 -> absEndPos.x, subtract -1 again, to be sure we don't
select text too far after the end position, making the selection currently disappear, which
is a bug, but can be avoided in this testcase.
* platform/chromium/test_expectations.txt: Unskip test.
* svg/text/resources/SelectionTestCase.js:
(selectRange): Subtract -1 from absEndPos.x.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (105400 => 105401)
--- trunk/LayoutTests/ChangeLog 2012-01-19 11:18:44 UTC (rev 105400)
+++ trunk/LayoutTests/ChangeLog 2012-01-19 12:17:09 UTC (rev 105401)
@@ -1,3 +1,19 @@
+2012-01-19 Nikolas Zimmermann <nzimmerm...@rim.com>
+
+ RenderSVGRoot should inherit from RenderReplaced
+ https://bugs.webkit.org/show_bug.cgi?id=76446
+
+ Reviewed by Pavel Feldman.
+
+ Fix Chromium specific problem with svg/text/select-x-list-4.svg, making it fail on the bots.
+ After transforming the endPos.x + 1 -> absEndPos.x, subtract -1 again, to be sure we don't
+ select text too far after the end position, making the selection currently disappear, which
+ is a bug, but can be avoided in this testcase.
+
+ * platform/chromium/test_expectations.txt: Unskip test.
+ * svg/text/resources/SelectionTestCase.js:
+ (selectRange): Subtract -1 from absEndPos.x.
+
2012-01-19 Csaba Osztrogonác <o...@webkit.org>
[Qt] Unreviewed gardening. Unskip now passing tests.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (105400 => 105401)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-19 11:18:44 UTC (rev 105400)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-19 12:17:09 UTC (rev 105401)
@@ -3856,8 +3856,6 @@
BUGWK76562 : fast/canvas/webgl/drawingbuffer-test.html = TEXT
-BUGWK76446 : svg/text/select-x-list-4.svg = IMAGE+TEXT
-
// This test is passing, but it doesn't seem possible to add GPU+Leopard specific baselines.
BUGJAMESR LEOPARD GPU : fast/canvas/quadraticCurveTo.xml = IMAGE
Modified: trunk/LayoutTests/svg/text/resources/SelectionTestCase.js (105400 => 105401)
--- trunk/LayoutTests/svg/text/resources/SelectionTestCase.js 2012-01-19 11:18:44 UTC (rev 105400)
+++ trunk/LayoutTests/svg/text/resources/SelectionTestCase.js 2012-01-19 12:17:09 UTC (rev 105401)
@@ -66,6 +66,7 @@
var absStartPos = toAbsoluteCoordinates(startPos, element);
var absEndPos = toAbsoluteCoordinates(endPos, element);
+ absEndPos.x -= 1;
// Move to selection origin and hold down mouse
eventSender.mouseMoveTo(absStartPos.x, absStartPos.y);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
