Title: [272157] branches/safari-611-branch/LayoutTests
- Revision
- 272157
- Author
- [email protected]
- Date
- 2021-02-01 12:11:38 -0800 (Mon, 01 Feb 2021)
Log Message
Cherry-pick r271736. rdar://problem/73838912
REGRESSION (r271472): [ Mac WK2 ] intersection-observer/target-deleted.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=220637
<rdar://problem/73220571>
Reviewed by Simon Fraser.
* intersection-observer/target-deleted.html:
For some reason, on some configurations, this test recently stopped seeing its
intersection observer get garbage collected when it expects. The regression
point is likely irrelevant, though multiple bots agree.
Doing a full rendering update by using rAF instead of just a setInterval
seems to be enough to get the object to actually be collected promptly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/LayoutTests/ChangeLog (272156 => 272157)
--- branches/safari-611-branch/LayoutTests/ChangeLog 2021-02-01 20:11:36 UTC (rev 272156)
+++ branches/safari-611-branch/LayoutTests/ChangeLog 2021-02-01 20:11:38 UTC (rev 272157)
@@ -1,3 +1,40 @@
+2021-02-01 Alan Coon <[email protected]>
+
+ Cherry-pick r271736. rdar://problem/73838912
+
+ REGRESSION (r271472): [ Mac WK2 ] intersection-observer/target-deleted.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=220637
+ <rdar://problem/73220571>
+
+ Reviewed by Simon Fraser.
+
+ * intersection-observer/target-deleted.html:
+ For some reason, on some configurations, this test recently stopped seeing its
+ intersection observer get garbage collected when it expects. The regression
+ point is likely irrelevant, though multiple bots agree.
+
+ Doing a full rendering update by using rAF instead of just a setInterval
+ seems to be enough to get the object to actually be collected promptly.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-21 Tim Horton <[email protected]>
+
+ REGRESSION (r271472): [ Mac WK2 ] intersection-observer/target-deleted.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=220637
+ <rdar://problem/73220571>
+
+ Reviewed by Simon Fraser.
+
+ * intersection-observer/target-deleted.html:
+ For some reason, on some configurations, this test recently stopped seeing its
+ intersection observer get garbage collected when it expects. The regression
+ point is likely irrelevant, though multiple bots agree.
+
+ Doing a full rendering update by using rAF instead of just a setInterval
+ seems to be enough to get the object to actually be collected promptly.
+
2021-01-29 Alan Coon <[email protected]>
Cherry-pick r271507. rdar://problem/73473467
Modified: branches/safari-611-branch/LayoutTests/intersection-observer/target-deleted.html (272156 => 272157)
--- branches/safari-611-branch/LayoutTests/intersection-observer/target-deleted.html 2021-02-01 20:11:36 UTC (rev 272156)
+++ branches/safari-611-branch/LayoutTests/intersection-observer/target-deleted.html 2021-02-01 20:11:38 UTC (rev 272157)
@@ -11,13 +11,15 @@
function observerShouldBeRemoved()
{
return new Promise(function(resolve) {
- handle = setInterval(function() {
+ function testIfRemoved() {
gc();
- if (internals && internals.numberOfIntersectionObservers(document) == 0) {
- clearInterval(handle);
+ if (internals && internals.numberOfIntersectionObservers(document) == 0)
resolve();
- }
- }, 10);
+ else
+ requestAnimationFrame(testIfRemoved);
+ }
+
+ testIfRemoved();
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
