Title: [272423] trunk/Tools
- Revision
- 272423
- Author
- aakash_j...@apple.com
- Date
- 2021-02-05 10:31:43 -0800 (Fri, 05 Feb 2021)
Log Message
[ews] commit-queue should use commits.webkit.org url instead of trac url
https://bugs.webkit.org/show_bug.cgi?id=221476
Reviewed by Jonathan Bedard.
* CISupport/ews-build/steps.py:
(PushCommitToWebKitRepo.url_for_revision):
* CISupport/ews-build/steps_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (272422 => 272423)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-02-05 18:27:56 UTC (rev 272422)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-02-05 18:31:43 UTC (rev 272423)
@@ -3106,7 +3106,7 @@
return rc
def url_for_revision(self, revision):
- return 'https://trac.webkit.org/changeset/{}'.format(revision)
+ return 'https://commits.webkit.org/r{}'.format(revision)
def comment_text_for_bug(self, svn_revision=None):
patch_id = self.getProperty('patch_id', '')
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (272422 => 272423)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-02-05 18:27:56 UTC (rev 272422)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-02-05 18:31:43 UTC (rev 272423)
@@ -3749,7 +3749,7 @@
)
self.expectOutcome(result=SUCCESS, state_string='Committed r256729')
rc = self.runStep()
- self.assertEqual(self.getProperty('bugzilla_comment_text'), 'Committed r256729: <https://trac.webkit.org/changeset/256729>\n\nAll reviewed patches have been landed. Closing bug and clearing flags on attachment 1234.')
+ self.assertEqual(self.getProperty('bugzilla_comment_text'), 'Committed r256729: <https://commits.webkit.org/r256729>\n\nAll reviewed patches have been landed. Closing bug and clearing flags on attachment 1234.')
self.assertEqual(self.getProperty('build_finish_summary'), None)
return rc
Modified: trunk/Tools/ChangeLog (272422 => 272423)
--- trunk/Tools/ChangeLog 2021-02-05 18:27:56 UTC (rev 272422)
+++ trunk/Tools/ChangeLog 2021-02-05 18:31:43 UTC (rev 272423)
@@ -1,3 +1,14 @@
+2021-02-05 Aakash Jain <aakash_j...@apple.com>
+
+ [ews] commit-queue should use commits.webkit.org url instead of trac url
+ https://bugs.webkit.org/show_bug.cgi?id=221476
+
+ Reviewed by Jonathan Bedard.
+
+ * CISupport/ews-build/steps.py:
+ (PushCommitToWebKitRepo.url_for_revision):
+ * CISupport/ews-build/steps_unittest.py:
+
2021-02-05 Lauro Moura <lmo...@igalia.com>
[Flatpak SDK] Print stderr when coredumpctl fails
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
