Diff
Modified: trunk/Tools/CISupport/ews-build/factories.py (272663 => 272664)
--- trunk/Tools/CISupport/ews-build/factories.py 2021-02-10 18:46:57 UTC (rev 272663)
+++ trunk/Tools/CISupport/ews-build/factories.py 2021-02-10 19:01:15 UTC (rev 272664)
@@ -28,7 +28,7 @@
CheckPatchStatusOnEWSQueues, CheckStyle, CompileJSC, CompileWebKit, ConfigureBuild, CreateLocalGITCommit,
DownloadBuiltProduct, ExtractBuiltProduct, FindModifiedChangeLogs, InstallGtkDependencies,
InstallWpeDependencies, KillOldProcesses, PrintConfiguration, PushCommitToWebKitRepo,
- RunAPITests, RunBindingsTests, RunBuildWebKitOrgUnitTests, RunBuildWebKitOrgOldUnitTests, RunEWSBuildbotCheckConfig, RunEWSUnitTests,
+ RunAPITests, RunBindingsTests, RunBuildWebKitOrgUnitTests, RunEWSBuildbotCheckConfig, RunEWSUnitTests,
RunResultsdbpyTests, RunJavaScriptCoreTests, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyPython2Tests,
RunWebKitPyPython3Tests, RunWebKitTests, SetBuildSummary, ShowIdentifier, TriggerCrashLogSubmission, UpdateWorkingDirectory,
ValidatePatch, ValidateChangeLogAndReviewer, ValidateCommiterAndReviewer, WaitForCrashCollection)
@@ -246,7 +246,6 @@
def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
Factory.__init__(self, platform=platform, configuration=configuration, architectures=architectures, buildOnly=False, additionalArguments=additionalArguments, checkRelevance=True)
self.addStep(RunBuildWebKitOrgUnitTests())
- self.addStep(RunBuildWebKitOrgOldUnitTests())
self.addStep(RunEWSUnitTests())
self.addStep(RunEWSBuildbotCheckConfig())
self.addStep(RunResultsdbpyTests())
Modified: trunk/Tools/CISupport/ews-build/factories_unittest.py (272663 => 272664)
--- trunk/Tools/CISupport/ews-build/factories_unittest.py 2021-02-10 18:46:57 UTC (rev 272663)
+++ trunk/Tools/CISupport/ews-build/factories_unittest.py 2021-02-10 19:01:15 UTC (rev 272664)
@@ -166,7 +166,6 @@
_BuildStepFactory(steps.ShowIdentifier),
_BuildStepFactory(steps.ApplyPatch),
_BuildStepFactory(steps.RunBuildWebKitOrgUnitTests),
- _BuildStepFactory(steps.RunBuildWebKitOrgOldUnitTests),
_BuildStepFactory(steps.RunEWSUnitTests),
_BuildStepFactory(steps.RunEWSBuildbotCheckConfig),
_BuildStepFactory(steps.RunResultsdbpyTests),
Modified: trunk/Tools/CISupport/ews-build/steps.py (272663 => 272664)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-02-10 18:46:57 UTC (rev 272663)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-02-10 19:01:15 UTC (rev 272664)
@@ -1196,20 +1196,6 @@
return shell.ShellCommand.evaluateCommand(self, cmd)
-class RunBuildWebKitOrgOldUnitTests(shell.ShellCommand):
- name = 'build-webkit-old-unit-tests'
- description = ['build-webkit-unit-tests running']
- command = ['python', 'steps_unittest_old.py']
-
- def __init__(self, **kwargs):
- shell.ShellCommand.__init__(self, workdir='build/Tools/CISupport/build-webkit-org', timeout=2 * 60, logEnviron=False, **kwargs)
-
- def getResultSummary(self):
- if self.results == SUCCESS:
- return {u'step': u'Passed build.webkit.org old unit tests'}
- return {u'step': u'Failed build.webkit.org old unit tests'}
-
-
class RunBuildWebKitOrgUnitTests(shell.ShellCommand):
name = 'build-webkit-org-unit-tests'
description = ['build-webkit-unit-tests running']
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (272663 => 272664)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-02-10 18:46:57 UTC (rev 272663)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-02-10 19:01:15 UTC (rev 272664)
@@ -47,7 +47,7 @@
FindModifiedChangeLogs, InstallGtkDependencies, InstallWpeDependencies, KillOldProcesses,
PrintConfiguration, PushCommitToWebKitRepo, ReRunAPITests, ReRunJavaScriptCoreTests, ReRunWebKitPerlTests,
ReRunWebKitTests, RunAPITests, RunAPITestsWithoutPatch, RunBindingsTests, RunBuildWebKitOrgUnitTests,
- RunBuildWebKitOrgOldUnitTests, RunEWSBuildbotCheckConfig, RunEWSUnitTests, RunResultsdbpyTests, RunJavaScriptCoreTests,
+ RunEWSBuildbotCheckConfig, RunEWSUnitTests, RunResultsdbpyTests, RunJavaScriptCoreTests,
RunJSCTestsWithoutPatch, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyPython2Tests,
RunWebKitPyPython3Tests, RunWebKitTests, RunWebKitTestsWithoutPatch, TestWithFailureCount, ShowIdentifier,
Trigger, TransferToS3, UnApplyPatchIfRequired, UpdateWorkingDirectory, UploadBuiltProduct,
@@ -761,42 +761,6 @@
return self.runStep()
-class TestRunBuildWebKitOrgOldUnitTests(BuildStepMixinAdditions, unittest.TestCase):
- def setUp(self):
- self.longMessage = True
- return self.setUpBuildStep()
-
- def tearDown(self):
- return self.tearDownBuildStep()
-
- def test_success(self):
- self.setupStep(RunBuildWebKitOrgOldUnitTests())
- self.expectRemoteCommands(
- ExpectShell(workdir='build/Tools/CISupport/build-webkit-org',
- timeout=120,
- logEnviron=False,
- command=['python', 'steps_unittest_old.py'],
- )
- + 0,
- )
- self.expectOutcome(result=SUCCESS, state_string='Passed build.webkit.org old unit tests')
- return self.runStep()
-
- def test_failure(self):
- self.setupStep(RunBuildWebKitOrgOldUnitTests())
- self.expectRemoteCommands(
- ExpectShell(workdir='build/Tools/CISupport/build-webkit-org',
- timeout=120,
- logEnviron=False,
- command=['python', 'steps_unittest_old.py'],
- )
- + ExpectShell.log('stdio', stdout='Unhandled Error. Traceback (most recent call last): Keys in cmd missing from expectation: [logfiles.json]')
- + 2,
- )
- self.expectOutcome(result=FAILURE, state_string='Failed build.webkit.org old unit tests')
- return self.runStep()
-
-
class TestKillOldProcesses(BuildStepMixinAdditions, unittest.TestCase):
def setUp(self):
self.longMessage = True
Modified: trunk/Tools/ChangeLog (272663 => 272664)
--- trunk/Tools/ChangeLog 2021-02-10 18:46:57 UTC (rev 272663)
+++ trunk/Tools/ChangeLog 2021-02-10 19:01:15 UTC (rev 272664)
@@ -1,3 +1,27 @@
+2021-02-10 Aakash Jain <aakash_j...@apple.com>
+
+ [ews] Remove old build.webkit.org unit-tests
+ https://bugs.webkit.org/show_bug.cgi?id=221678
+
+ Reviewed by Jonathan Bedard.
+
+ * CISupport/ews-build/factories.py:
+ (ServicesFactory.__init__):
+ * CISupport/ews-build/factories_unittest.py:
+ (TestTestsFactory.test_services_factory):
+ * CISupport/ews-build/steps.py:
+ (ReRunWebKitPerlTests.evaluateCommand):
+ (RunBuildWebKitOrgOldUnitTests): Deleted.
+ (RunBuildWebKitOrgOldUnitTests.__init__): Deleted.
+ (RunBuildWebKitOrgOldUnitTests.getResultSummary): Deleted.
+ * CISupport/ews-build/steps_unittest.py:
+ (TestRunBuildWebKitOrgUnitTests.test_failure):
+ (TestRunBuildWebKitOrgOldUnitTests): Deleted.
+ (TestRunBuildWebKitOrgOldUnitTests.setUp): Deleted.
+ (TestRunBuildWebKitOrgOldUnitTests.tearDown): Deleted.
+ (TestRunBuildWebKitOrgOldUnitTests.test_success): Deleted.
+ (TestRunBuildWebKitOrgOldUnitTests.test_failure): Deleted.
+
2021-02-10 Patrick Griffis <pgrif...@igalia.com>
Update status in contributors.json
