Title: [272679] trunk/Source
- Revision
- 272679
- Author
- a...@apple.com
- Date
- 2021-02-10 12:55:02 -0800 (Wed, 10 Feb 2021)
Log Message
Do not differentiate between Release and Production via ENABLE_DEVELOPER_MODE
https://bugs.webkit.org/show_bug.cgi?id=221684
Reviewed by Sam Weinig.
It is invalid to create behaviors that are different between these. There is
almost no difference in usage scenarios between build modes - either can be
produced by CI for validation, either can be used for local testing, etc.
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
Source/WebCore:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (272678 => 272679)
--- trunk/Source/WebCore/ChangeLog 2021-02-10 20:34:18 UTC (rev 272678)
+++ trunk/Source/WebCore/ChangeLog 2021-02-10 20:55:02 UTC (rev 272679)
@@ -1,3 +1,19 @@
+2021-02-10 Alexey Proskuryakov <a...@apple.com>
+
+ Do not differentiate between Release and Production via ENABLE_DEVELOPER_MODE
+ https://bugs.webkit.org/show_bug.cgi?id=221684
+
+ Reviewed by Sam Weinig.
+
+ It is invalid to create behaviors that are different between these. There is
+ almost no difference in usage scenarios between build modes - either can be
+ produced by CI for validation, either can be used for local testing, etc.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
+
2021-02-10 Chris Dumez <cdu...@apple.com>
WebCore::createBusFromInMemoryAudioFile() may crash under ExtAudioFileRead()
Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (272678 => 272679)
--- trunk/Source/WebCore/Configurations/Base.xcconfig 2021-02-10 20:34:18 UTC (rev 272678)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2021-02-10 20:55:02 UTC (rev 272679)
@@ -70,7 +70,6 @@
GCC_NO_COMMON_BLOCKS = YES;
GCC_OBJC_CALL_CXX_CDTORS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
-GCC_PREPROCESSOR_DEFINITIONS = $(inherited) $(DEVELOPER_MODE_DEFINES);
GCC_SYMBOLS_PRIVATE_EXTERN = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
@@ -93,9 +92,6 @@
GCC_WARN_UNUSED_VARIABLE = YES;
WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wno-unknown-warning-option -Wliteral-conversion;
-DEVELOPER_MODE_DEFINES = $(DEVELOPER_MODE_DEFINES_$(DEVELOPER_MODE));
-DEVELOPER_MODE_DEFINES_1 = ENABLE_DEVELOPER_MODE=1;
-
TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = $(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_$(MACOSX_DEPLOYMENT_TARGET:base))
TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
Modified: trunk/Source/WebCore/Configurations/DebugRelease.xcconfig (272678 => 272679)
--- trunk/Source/WebCore/Configurations/DebugRelease.xcconfig 2021-02-10 20:34:18 UTC (rev 272678)
+++ trunk/Source/WebCore/Configurations/DebugRelease.xcconfig 2021-02-10 20:55:02 UTC (rev 272679)
@@ -49,8 +49,6 @@
MACOSX_DEPLOYMENT_TARGET_110000 = 11.0;
MACOSX_DEPLOYMENT_TARGET_120000 = 12.0;
-DEVELOPER_MODE = 1;
-
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (272678 => 272679)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-02-10 20:34:18 UTC (rev 272678)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-02-10 20:55:02 UTC (rev 272679)
@@ -7156,7 +7156,7 @@
if (functionValue.isCallable(vm))
return true;
-#if ENABLE(DEVELOPER_MODE) || !defined(NDEBUG)
+#if !defined(NDEBUG)
// Setting a scriptURL allows the source to be debuggable in the inspector.
URL scriptURL = URL({ }, "mediaControlsScript"_s);
#else
Modified: trunk/Source/WebInspectorUI/ChangeLog (272678 => 272679)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-02-10 20:34:18 UTC (rev 272678)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-02-10 20:55:02 UTC (rev 272679)
@@ -1,3 +1,17 @@
+2021-02-10 Alexey Proskuryakov <a...@apple.com>
+
+ Do not differentiate between Release and Production via ENABLE_DEVELOPER_MODE
+ https://bugs.webkit.org/show_bug.cgi?id=221684
+
+ Reviewed by Sam Weinig.
+
+ It is invalid to create behaviors that are different between these. There is
+ almost no difference in usage scenarios between build modes - either can be
+ produced by CI for validation, either can be used for local testing, etc.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+
2021-02-10 Razvan Caliman <rcali...@apple.com>
Web Inspector: Display all CSS grids on page in Layout panel
Modified: trunk/Source/WebInspectorUI/Configurations/Base.xcconfig (272678 => 272679)
--- trunk/Source/WebInspectorUI/Configurations/Base.xcconfig 2021-02-10 20:34:18 UTC (rev 272678)
+++ trunk/Source/WebInspectorUI/Configurations/Base.xcconfig 2021-02-10 20:55:02 UTC (rev 272679)
@@ -45,7 +45,6 @@
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = NO;
-GCC_PREPROCESSOR_DEFINITIONS = $(inherited) $(DEVELOPER_MODE_DEFINES);
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
@@ -64,9 +63,6 @@
GCC_WARN_UNUSED_VARIABLE = YES
WARNING_CFLAGS = -Wall -W -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wexit-time-destructors -Wvla -Wliteral-conversion;
-DEVELOPER_MODE_DEFINES = $(DEVELOPER_MODE_DEFINES_$(DEVELOPER_MODE));
-DEVELOPER_MODE_DEFINES_1 = ENABLE_DEVELOPER_MODE=1;
-
SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
SUPPORTS_MACCATALYST = YES;
Modified: trunk/Source/WebInspectorUI/Configurations/DebugRelease.xcconfig (272678 => 272679)
--- trunk/Source/WebInspectorUI/Configurations/DebugRelease.xcconfig 2021-02-10 20:34:18 UTC (rev 272678)
+++ trunk/Source/WebInspectorUI/Configurations/DebugRelease.xcconfig 2021-02-10 20:55:02 UTC (rev 272679)
@@ -26,8 +26,6 @@
MACOSX_DEPLOYMENT_TARGET_110000 = 11.0;
MACOSX_DEPLOYMENT_TARGET_120000 = 12.0;
-DEVELOPER_MODE = 1;
-
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
