Title: [272708] trunk/Source/WebKit
- Revision
- 272708
- Author
- [email protected]
- Date
- 2021-02-10 22:26:32 -0800 (Wed, 10 Feb 2021)
Log Message
[WebAuthn] Update - [ASCAppleIDCredential initWithUser:...] to match the latest SPI
https://bugs.webkit.org/show_bug.cgi?id=221723
<rdar://problem/74038383>
Reviewed by Brent Fulgham.
No tests.
* Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
* UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
(WebKit::AuthenticatorPresenterCoordinator::dimissPresenter):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (272707 => 272708)
--- trunk/Source/WebKit/ChangeLog 2021-02-11 06:22:38 UTC (rev 272707)
+++ trunk/Source/WebKit/ChangeLog 2021-02-11 06:26:32 UTC (rev 272708)
@@ -1,3 +1,17 @@
+2021-02-10 Jiewen Tan <[email protected]>
+
+ [WebAuthn] Update - [ASCAppleIDCredential initWithUser:...] to match the latest SPI
+ https://bugs.webkit.org/show_bug.cgi?id=221723
+ <rdar://problem/74038383>
+
+ Reviewed by Brent Fulgham.
+
+ No tests.
+
+ * Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
+ * UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
+ (WebKit::AuthenticatorPresenterCoordinator::dimissPresenter):
+
2021-02-10 Rob Buis <[email protected]>
Use event loop to set title
Modified: trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h (272707 => 272708)
--- trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h 2021-02-11 06:22:38 UTC (rev 272707)
+++ trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h 2021-02-11 06:26:32 UTC (rev 272708)
@@ -155,7 +155,7 @@
- (instancetype)init NS_UNAVAILABLE;
+ (instancetype)new NS_UNAVAILABLE;
-- (instancetype)initWithUser:(NSString *)user identityToken:(NSData *)identityToken;
+- (instancetype)initWithUser:(NSString *)user identityToken:(nullable NSData *)identityToken state:(nullable NSString *)state;
@property (nonatomic, readonly, copy) NSString *user;
@property (nonatomic, readonly, copy, nullable) NSData *identityToken;
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm (272707 => 272708)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm 2021-02-11 06:22:38 UTC (rev 272707)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm 2021-02-11 06:26:32 UTC (rev 272708)
@@ -241,7 +241,7 @@
if (result == WebAuthenticationResult::Succeeded && m_credentialRequestHandler) {
// FIXME(219767): Replace the ASCAppleIDCredential with the upcoming WebAuthn credentials one.
// This is just a place holder to tell the UI that the ceremony succeeds.
- m_credentialRequestHandler(adoptNS([WebKit::allocASCAppleIDCredentialInstance() initWithUser:@"" identityToken:adoptNS([[NSData alloc] init]).get()]).get(), nil);
+ m_credentialRequestHandler(adoptNS([WebKit::allocASCAppleIDCredentialInstance() initWithUser:@"" identityToken:adoptNS([[NSData alloc] init]).get() state:nil]).get(), nil);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
