Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (272767 => 272768)
--- trunk/Source/_javascript_Core/ChangeLog 2021-02-12 02:19:42 UTC (rev 272767)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-02-12 02:56:51 UTC (rev 272768)
@@ -1,3 +1,14 @@
+2021-02-11 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: "Show Extended Gridlines" option for grid overlay does not work
+ https://bugs.webkit.org/show_bug.cgi?id=221775
+
+ Reviewed by Devin Rousso.
+
+ Replace all mentions of "Gridlines" with "GridLines" (camelcase).
+
+ * inspector/protocol/DOM.json:
+
2021-02-11 Mark Lam <mark....@apple.com>
CodeBlock::propagateTransitions() should also handle OpSetPrivateBrand's LLInt IC.
Modified: trunk/Source/_javascript_Core/inspector/protocol/DOM.json (272767 => 272768)
--- trunk/Source/_javascript_Core/inspector/protocol/DOM.json 2021-02-12 02:19:42 UTC (rev 272767)
+++ trunk/Source/_javascript_Core/inspector/protocol/DOM.json 2021-02-12 02:56:51 UTC (rev 272768)
@@ -503,7 +503,7 @@
{ "name": "gridColor", "$ref": "RGBAColor", "description": "The primary color to use for the grid overlay." },
{ "name": "showLineNames", "type": "boolean", "optional": true, "description": "Show labels for grid line names. If not specified, the default value is false." },
{ "name": "showLineNumbers", "type": "boolean", "optional": true, "description": "Show labels for grid line numbers. If not specified, the default value is false." },
- { "name": "showExtendedGridlines", "type": "boolean", "optional": true, "description": "Show grid lines that extend beyond the bounds of the grid. If not specified, the default value is false." },
+ { "name": "showExtendedGridLines", "type": "boolean", "optional": true, "description": "Show grid lines that extend beyond the bounds of the grid. If not specified, the default value is false." },
{ "name": "showTrackSizes", "type": "boolean", "optional": true, "description": "Show grid track size information. If not specified, the default value is false." },
{ "name": "showAreaNames", "type": "boolean", "optional": true, "description": "Show labels for grid area names. If not specified, the default value is false." }
]
Modified: trunk/Source/WebCore/ChangeLog (272767 => 272768)
--- trunk/Source/WebCore/ChangeLog 2021-02-12 02:19:42 UTC (rev 272767)
+++ trunk/Source/WebCore/ChangeLog 2021-02-12 02:56:51 UTC (rev 272768)
@@ -1,3 +1,17 @@
+2021-02-11 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: "Show Extended Gridlines" option for grid overlay does not work
+ https://bugs.webkit.org/show_bug.cgi?id=221775
+
+ Reviewed by Devin Rousso.
+
+ Replace all mentions of "Gridlines" with "GridLines" (camelcase).
+
+ * inspector/InspectorOverlay.h:
+ * inspector/agents/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::showGridOverlay):
+ * inspector/agents/InspectorDOMAgent.h:
+
2021-02-11 Alex Christensen <achristen...@webkit.org>
REGRESSION(r272293) WebGL 1.0.2 test expectations say HTTPS
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.h (272767 => 272768)
--- trunk/Source/WebCore/inspector/InspectorOverlay.h 2021-02-12 02:19:42 UTC (rev 272767)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.h 2021-02-12 02:56:51 UTC (rev 272768)
@@ -115,7 +115,7 @@
Color gridColor;
bool showLineNames;
bool showLineNumbers;
- bool showExtendedGridlines;
+ bool showExtendedGridLines;
bool showTrackSizes;
bool showAreaNames;
};
Modified: trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp (272767 => 272768)
--- trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp 2021-02-12 02:19:42 UTC (rev 272767)
+++ trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp 2021-02-12 02:56:51 UTC (rev 272768)
@@ -1477,7 +1477,7 @@
return { };
}
-Inspector::Protocol::ErrorStringOr<void> InspectorDOMAgent::showGridOverlay(Inspector::Protocol::DOM::NodeId nodeId, Ref<JSON::Object>&& gridColor, Optional<bool>&& showLineNames, Optional<bool>&& showLineNumbers, Optional<bool>&& showExtendedGridlines, Optional<bool>&& showTrackSizes, Optional<bool>&& showAreaNames)
+Inspector::Protocol::ErrorStringOr<void> InspectorDOMAgent::showGridOverlay(Inspector::Protocol::DOM::NodeId nodeId, Ref<JSON::Object>&& gridColor, Optional<bool>&& showLineNames, Optional<bool>&& showLineNumbers, Optional<bool>&& showExtendedGridLines, Optional<bool>&& showTrackSizes, Optional<bool>&& showAreaNames)
{
Protocol::ErrorString errorString;
Node* node = assertNode(errorString, nodeId);
@@ -1492,7 +1492,7 @@
config.gridColor = *parsedColor;
config.showLineNames = showLineNames.valueOr(false);
config.showLineNumbers = showLineNumbers.valueOr(false);
- config.showExtendedGridlines = showExtendedGridlines.valueOr(false);
+ config.showExtendedGridLines = showExtendedGridLines.valueOr(false);
config.showTrackSizes = showTrackSizes.valueOr(false);
config.showAreaNames = showAreaNames.valueOr(false);
Modified: trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h (272767 => 272768)
--- trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h 2021-02-12 02:19:42 UTC (rev 272767)
+++ trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h 2021-02-12 02:56:51 UTC (rev 272768)
@@ -144,7 +144,7 @@
Inspector::Protocol::ErrorStringOr<void> highlightNode(Ref<JSON::Object>&& highlightConfig, Optional<Inspector::Protocol::DOM::NodeId>&&, const Inspector::Protocol::Runtime::RemoteObjectId&);
Inspector::Protocol::ErrorStringOr<void> highlightNodeList(Ref<JSON::Array>&& nodeIds, Ref<JSON::Object>&& highlightConfig);
Inspector::Protocol::ErrorStringOr<void> highlightFrame(const Inspector::Protocol::Network::FrameId&, RefPtr<JSON::Object>&& color, RefPtr<JSON::Object>&& outlineColor);
- Inspector::Protocol::ErrorStringOr<void> showGridOverlay(Inspector::Protocol::DOM::NodeId, Ref<JSON::Object>&& gridColor, Optional<bool>&& showLineNames, Optional<bool>&& showLineNumbers, Optional<bool>&& showExtendedGridlines, Optional<bool>&& showTrackSizes, Optional<bool>&& showAreaNames);
+ Inspector::Protocol::ErrorStringOr<void> showGridOverlay(Inspector::Protocol::DOM::NodeId, Ref<JSON::Object>&& gridColor, Optional<bool>&& showLineNames, Optional<bool>&& showLineNumbers, Optional<bool>&& showExtendedGridLines, Optional<bool>&& showTrackSizes, Optional<bool>&& showAreaNames);
Inspector::Protocol::ErrorStringOr<void> hideGridOverlay(Optional<Inspector::Protocol::DOM::NodeId>&&);
Inspector::Protocol::ErrorStringOr<Inspector::Protocol::DOM::NodeId> moveTo(Inspector::Protocol::DOM::NodeId nodeId, Inspector::Protocol::DOM::NodeId targetNodeId, Optional<Inspector::Protocol::DOM::NodeId>&& insertBeforeNodeId);
Inspector::Protocol::ErrorStringOr<void> undo();
