Title: [273095] trunk/Source/WebKit
- Revision
- 273095
- Author
- hironori.fu...@sony.com
- Date
- 2021-02-18 12:46:57 -0800 (Thu, 18 Feb 2021)
Log Message
Unreviewed, reverting r273063.
GTK port layout tests are timint out.
Reverted changeset:
"[CoordinatedGraphics] The whole content is unnecessarily
repainted by animations in non-AC mode pages"
https://bugs.webkit.org/show_bug.cgi?id=221391
https://commits.webkit.org/r273063
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (273094 => 273095)
--- trunk/Source/WebKit/ChangeLog 2021-02-18 20:38:02 UTC (rev 273094)
+++ trunk/Source/WebKit/ChangeLog 2021-02-18 20:46:57 UTC (rev 273095)
@@ -1,3 +1,16 @@
+2021-02-18 Fujii Hironori <hironori.fu...@sony.com>
+
+ Unreviewed, reverting r273063.
+
+ GTK port layout tests are timint out.
+
+ Reverted changeset:
+
+ "[CoordinatedGraphics] The whole content is unnecessarily
+ repainted by animations in non-AC mode pages"
+ https://bugs.webkit.org/show_bug.cgi?id=221391
+ https://commits.webkit.org/r273063
+
2021-02-18 Per Arne <pvol...@apple.com>
[macOS] Remove access to audio IOKit
Modified: trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (273094 => 273095)
--- trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2021-02-18 20:38:02 UTC (rev 273094)
+++ trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2021-02-18 20:46:57 UTC (rev 273095)
@@ -356,7 +356,7 @@
if (m_layerTreeHost)
m_layerTreeHost->scheduleLayerFlush();
else
- scheduleDisplay();
+ setNeedsDisplay();
}
#if USE(COORDINATED_GRAPHICS)
@@ -473,10 +473,6 @@
m_isWaitingForDidUpdate = false;
- if (!m_scheduledWhileWaitingForDidUpdate)
- return;
- m_scheduledWhileWaitingForDidUpdate = false;
-
// Display if needed. We call displayTimerFired here since it will throttle updates to 60fps.
displayTimerFired();
}
@@ -681,14 +677,15 @@
{
ASSERT(!m_layerTreeHost);
- if (m_isWaitingForDidUpdate) {
- m_scheduledWhileWaitingForDidUpdate = true;
+ if (m_isWaitingForDidUpdate)
return;
- }
if (m_isPaintingSuspended)
return;
+ if (m_dirtyRegion.isEmpty())
+ return;
+
if (m_displayTimer.isActive())
return;
@@ -712,6 +709,9 @@
if (m_isPaintingSuspended)
return;
+ if (m_dirtyRegion.isEmpty())
+ return;
+
if (m_shouldSendDidUpdateBackingStoreState) {
sendDidUpdateBackingStoreState();
return;
@@ -720,9 +720,6 @@
UpdateInfo updateInfo;
display(updateInfo);
- if (updateInfo.updateRectBounds.isEmpty())
- return;
-
if (m_layerTreeHost) {
// The call to update caused layout which turned on accelerated compositing.
// Don't send an Update message in this case.
@@ -731,7 +728,6 @@
send(Messages::DrawingAreaProxy::Update(m_backingStoreStateID, updateInfo));
m_isWaitingForDidUpdate = true;
- m_scheduledWhileWaitingForDidUpdate = false;
}
static bool shouldPaintBoundsRect(const IntRect& bounds, const Vector<IntRect, 1>& rects)
@@ -770,9 +766,6 @@
if (m_layerTreeHost)
return;
- if (m_dirtyRegion.isEmpty())
- return;
-
updateInfo.viewSize = m_webPage.size();
updateInfo.deviceScaleFactor = m_webPage.corePage()->deviceScaleFactor();
Modified: trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h (273094 => 273095)
--- trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h 2021-02-18 20:38:02 UTC (rev 273094)
+++ trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h 2021-02-18 20:46:57 UTC (rev 273095)
@@ -143,7 +143,6 @@
// Whether we're waiting for a DidUpdate message. Used for throttling paints so that the
// web process won't paint more frequent than the UI process can handle.
bool m_isWaitingForDidUpdate { false };
- bool m_scheduledWhileWaitingForDidUpdate { false };
bool m_alwaysUseCompositing { false };
bool m_supportsAsyncScrolling { true };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
