Title: [273357] trunk/LayoutTests
Revision
273357
Author
[email protected]
Date
2021-02-23 16:26:11 -0800 (Tue, 23 Feb 2021)

Log Message

REGRESSION: media/modern-media-controls/volume-support/volume-support-click.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=222181
<rdar://problem/74527698>

Reviewed by Eric Carlson.

* media/modern-media-controls/volume-support/volume-support-click.html:
Add a rAF+0s delay before attempting to hover the mute button to give it a chance to
"settle" after it becomes visible (based off of `.getBoundingClientRect().width`).

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (273356 => 273357)


--- trunk/LayoutTests/ChangeLog	2021-02-23 23:13:12 UTC (rev 273356)
+++ trunk/LayoutTests/ChangeLog	2021-02-24 00:26:11 UTC (rev 273357)
@@ -1,3 +1,15 @@
+2021-02-23  Devin Rousso  <[email protected]>
+
+        REGRESSION: media/modern-media-controls/volume-support/volume-support-click.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=222181
+        <rdar://problem/74527698>
+
+        Reviewed by Eric Carlson.
+
+        * media/modern-media-controls/volume-support/volume-support-click.html:
+        Add a rAF+0s delay before attempting to hover the mute button to give it a chance to
+        "settle" after it becomes visible (based off of `.getBoundingClientRect().width`).
+
 2021-02-23  Robert Jenner  <[email protected]>
 
         [ Big Sur Wk1 ] http/tests/security/http-0.9/default-port-script-blocked.html is flakey timing out

Modified: trunk/LayoutTests/media/modern-media-controls/volume-support/volume-support-click.html (273356 => 273357)


--- trunk/LayoutTests/media/modern-media-controls/volume-support/volume-support-click.html	2021-02-23 23:13:12 UTC (rev 273356)
+++ trunk/LayoutTests/media/modern-media-controls/volume-support/volume-support-click.html	2021-02-24 00:26:11 UTC (rev 273357)
@@ -1,4 +1,5 @@
 <script src=""
+<script src=""
 <script src="" type="text/_javascript_"></script>
 <body>
 <style type="text/css" media="screen">
@@ -28,7 +29,9 @@
 const volumeSliderElement = mediaController.controls.volumeSlider.element;
 
 shouldBecomeEqual("media.paused", "false", () => {
-    shouldBecomeEqual("!!muteButtonElement.getBoundingClientRect().width", "true", () => {
+    shouldBecomeEqual("!!muteButtonElement.getBoundingClientRect().width", "true", async () => {
+        await UIHelper.renderingUpdate();
+
         // Controls are now visible, let's hover over the mute button to make the volume control visible.
         const muteButtonBounds = muteButtonElement.getBoundingClientRect();
         eventSender.mouseMoveTo(muteButtonBounds.left + muteButtonBounds.width / 2, muteButtonBounds.top + muteButtonBounds.height / 2);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to