Title: [273366] trunk/LayoutTests
Revision
273366
Author
[email protected]
Date
2021-02-23 17:41:31 -0800 (Tue, 23 Feb 2021)

Log Message

REGRESSION (r273004): [ macOS ] media/modern-media-controls/volume-support/volume-support-drag.html is a flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=222117
<rdar://problem/74484639>

Unreviewed, this is an identical change to r273357.


* media/modern-media-controls/volume-support/volume-support-drag.html:
Add a rAF+0s delay before attempting to hover the mute button to give it a chance to
"settle" after it becomes visible (based off of `.getBoundingClientRect().width`).

* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (273365 => 273366)


--- trunk/LayoutTests/ChangeLog	2021-02-24 01:11:03 UTC (rev 273365)
+++ trunk/LayoutTests/ChangeLog	2021-02-24 01:41:31 UTC (rev 273366)
@@ -1,5 +1,19 @@
 2021-02-23  Devin Rousso  <[email protected]>
 
+        REGRESSION (r273004): [ macOS ] media/modern-media-controls/volume-support/volume-support-drag.html is a flakey text failure
+        https://bugs.webkit.org/show_bug.cgi?id=222117
+        <rdar://problem/74484639>
+
+        Unreviewed, this is an identical change to r273357.
+
+        * media/modern-media-controls/volume-support/volume-support-drag.html:
+        Add a rAF+0s delay before attempting to hover the mute button to give it a chance to
+        "settle" after it becomes visible (based off of `.getBoundingClientRect().width`).
+
+        * platform/mac/TestExpectations:
+
+2021-02-23  Devin Rousso  <[email protected]>
+
         REGRESSION: media/modern-media-controls/volume-support/volume-support-click.html is a flaky timeout
         https://bugs.webkit.org/show_bug.cgi?id=222181
         <rdar://problem/74527698>

Modified: trunk/LayoutTests/media/modern-media-controls/volume-support/volume-support-drag.html (273365 => 273366)


--- trunk/LayoutTests/media/modern-media-controls/volume-support/volume-support-drag.html	2021-02-24 01:11:03 UTC (rev 273365)
+++ trunk/LayoutTests/media/modern-media-controls/volume-support/volume-support-drag.html	2021-02-24 01:41:31 UTC (rev 273366)
@@ -1,4 +1,5 @@
 <script src=""
+<script src=""
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <body>
@@ -33,7 +34,8 @@
 
 media.addEventListener("play", () => {
     media.pause();
-    shouldBecomeDifferent("muteButton.getBoundingClientRect().width", "0", () => {
+    shouldBecomeDifferent("muteButton.getBoundingClientRect().width", "0", async () => {
+        await UIHelper.renderingUpdate();
         const muteButtonBounds = muteButton.getBoundingClientRect();
         // Controls are now visible, let's hover over the mute button to make the volume control visible.
         eventSender.mouseMoveTo(muteButtonBounds.left + muteButtonBounds.width / 2, muteButtonBounds.top + muteButtonBounds.height / 2);

Modified: trunk/LayoutTests/platform/mac/TestExpectations (273365 => 273366)


--- trunk/LayoutTests/platform/mac/TestExpectations	2021-02-24 01:11:03 UTC (rev 273365)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-02-24 01:41:31 UTC (rev 273366)
@@ -2287,7 +2287,6 @@
 
 webkit.org/b/222118 [ BigSur+ ] imported/w3c/web-platform-tests/css/css-counter-styles/tibetan/css3-counter-styles-156.html [ ImageOnlyFailure ]
 
-webkit.org/b/222117 media/modern-media-controls/volume-support/volume-support-drag.html [ Pass Failure ]
 webkit.org/b/222117 media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html [ Pass Failure ]
 
 webkit.org/b/222185 media/media-extension-with-fragment.html [ Crash ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to