Title: [273424] trunk
- Revision
- 273424
- Author
- repst...@apple.com
- Date
- 2021-02-24 12:23:55 -0800 (Wed, 24 Feb 2021)
Log Message
Revert r272735. rdar://problem/74674837
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (273423 => 273424)
--- trunk/Source/WebKit/ChangeLog 2021-02-24 20:23:48 UTC (rev 273423)
+++ trunk/Source/WebKit/ChangeLog 2021-02-24 20:23:55 UTC (rev 273424)
@@ -1,5 +1,9 @@
2021-02-24 Russell Epstein <repst...@apple.com>
+ Revert r272735. rdar://problem/74674837
+
+2021-02-24 Russell Epstein <repst...@apple.com>
+
Revert r272810. rdar://problem/74674837
2021-02-24 Said Abou-Hallawa <s...@apple.com>
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (273423 => 273424)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-02-24 20:23:48 UTC (rev 273423)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-02-24 20:23:55 UTC (rev 273424)
@@ -183,13 +183,15 @@
bool defaultCaptureAudioInGPUProcessEnabled()
{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
#if PLATFORM(MAC)
- return true;
-#elif HAVE(SYSTEM_FEATURE_FLAGS)
+ return isFeatureFlagEnabled("gpu_process_webrtc");
+#elif PLATFORM(IOS_FAMILY)
return isFeatureFlagEnabled("gpu_process_media");
-#else
+#endif
+#endif
+
return false;
-#endif
}
bool defaultCaptureAudioInUIProcessEnabled()
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (273423 => 273424)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2021-02-24 20:23:48 UTC (rev 273423)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2021-02-24 20:23:55 UTC (rev 273424)
@@ -239,13 +239,11 @@
#if ENABLE(MEDIA_STREAM)
ALWAYS_LOG(LOGIDENTIFIER, request.userMediaID(), ", video: ", request.videoDevice().label(), ", audio: ", request.audioDevice().label());
- if (request.requestType() == MediaStreamRequest::Type::UserMedia)
- m_grantedRequests.append(makeRef(request));
-
if (auto callback = request.decisionCompletionHandler()) {
m_page.willStartCapture(request, [callback = WTFMove(callback)]() mutable {
callback(true);
});
+ m_grantedRequests.append(makeRef(request));
return;
}
@@ -274,6 +272,11 @@
if (!weakThis)
return;
+ auto& request = strongRequest.get();
+
+ if (request.requestType() == MediaStreamRequest::Type::UserMedia)
+ m_grantedRequests.append(makeRef(request));
+
// FIXME: m_hasFilteredDeviceList will trigger ondevicechange events for various documents from different origins.
if (m_hasFilteredDeviceList)
captureDevicesChanged(PermissionInfo::Granted);
@@ -289,7 +292,6 @@
}
#endif
- auto& request = strongRequest.get();
m_page.sendWithAsyncReply(Messages::WebPage::UserMediaAccessWasGranted { request.userMediaID(), request.audioDevice(), request.videoDevice(), request.deviceIdentifierHashSalt(), handle }, [this, weakThis = WTFMove(weakThis)] {
if (!weakThis)
return;
Modified: trunk/Tools/ChangeLog (273423 => 273424)
--- trunk/Tools/ChangeLog 2021-02-24 20:23:48 UTC (rev 273423)
+++ trunk/Tools/ChangeLog 2021-02-24 20:23:55 UTC (rev 273424)
@@ -1,3 +1,7 @@
+2021-02-24 Russell Epstein <repst...@apple.com>
+
+ Revert r272735. rdar://problem/74674837
+
2021-02-24 Aakash Jain <aakash_j...@apple.com>
Add unit-tests for various step in build.webkit.org (follow-up fix)
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm (273423 => 273424)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm 2021-02-24 20:23:48 UTC (rev 273423)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm 2021-02-24 20:23:55 UTC (rev 273424)
@@ -45,7 +45,7 @@
@implementation GetUserMediaRepromptTestView
- (BOOL)haveStream:(BOOL)expected
{
- int retryCount = 1000;
+ int retryCount = 10;
while (retryCount--) {
auto result = [self stringByEvaluatingJavaScript:@"haveStream()"];
if (result.boolValue == expected)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
