Title: [273442] trunk/Source/WebCore
- Revision
- 273442
- Author
- cdu...@apple.com
- Date
- 2021-02-24 15:02:00 -0800 (Wed, 24 Feb 2021)
Log Message
Regression(r269481) Kugou Music: Can not leave "MV" category after selecting it
https://bugs.webkit.org/show_bug.cgi?id=222380
<rdar://74602294>
Reviewed by Geoffrey Garen.
The new behavior in r269481 aligns us with the specification and with Blink so I
am adding a linked-on-after to maintain pre-r269481 behavior until Apps get
rebuilt against the new SDK.
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::supportedPropertyNames const):
* page/Quirks.cpp:
(WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames):
* page/Quirks.h:
* platform/cocoa/VersionChecks.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (273441 => 273442)
--- trunk/Source/WebCore/ChangeLog 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/ChangeLog 2021-02-24 23:02:00 UTC (rev 273442)
@@ -1,5 +1,24 @@
2021-02-24 Chris Dumez <cdu...@apple.com>
+ Regression(r269481) Kugou Music: Can not leave "MV" category after selecting it
+ https://bugs.webkit.org/show_bug.cgi?id=222380
+ <rdar://74602294>
+
+ Reviewed by Geoffrey Garen.
+
+ The new behavior in r269481 aligns us with the specification and with Blink so I
+ am adding a linked-on-after to maintain pre-r269481 behavior until Apps get
+ rebuilt against the new SDK.
+
+ * html/HTMLDocument.cpp:
+ (WebCore::HTMLDocument::supportedPropertyNames const):
+ * page/Quirks.cpp:
+ (WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames):
+ * page/Quirks.h:
+ * platform/cocoa/VersionChecks.h:
+
+2021-02-24 Chris Dumez <cdu...@apple.com>
+
Regression(r268700) postMessage changes prototype of basic types
https://bugs.webkit.org/show_bug.cgi?id=222228
<rdar://problem/74612853>
Modified: trunk/Source/WebCore/html/HTMLDocument.cpp (273441 => 273442)
--- trunk/Source/WebCore/html/HTMLDocument.cpp 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/html/HTMLDocument.cpp 2021-02-24 23:02:00 UTC (rev 273442)
@@ -74,6 +74,7 @@
#include "HTMLHtmlElement.h"
#include "HTMLIFrameElement.h"
#include "HTMLNames.h"
+#include "Quirks.h"
#include "ScriptController.h"
#include "StyleResolver.h"
#include <wtf/IsoMallocInlines.h>
@@ -140,6 +141,9 @@
Vector<AtomString> HTMLDocument::supportedPropertyNames() const
{
+ if (Quirks::shouldOmitHTMLDocumentSupportedPropertyNames())
+ return { };
+
auto properties = m_documentNamedItem.keys();
// The specification says these should be sorted in document order but this would be expensive
// and other browser engines do not comply with this part of the specification. For now, just
Modified: trunk/Source/WebCore/page/Quirks.cpp (273441 => 273442)
--- trunk/Source/WebCore/page/Quirks.cpp 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/page/Quirks.cpp 2021-02-24 23:02:00 UTC (rev 273442)
@@ -660,6 +660,16 @@
#endif
}
+bool Quirks::shouldOmitHTMLDocumentSupportedPropertyNames()
+{
+#if PLATFORM(COCOA)
+ static bool shouldOmitHTMLDocumentSupportedPropertyNames = !linkedOnOrAfter(SDKVersion::FirstWithHTMLDocumentSupportedPropertyNames);
+ return shouldOmitHTMLDocumentSupportedPropertyNames;
+#else
+ return false;
+#endif
+}
+
bool Quirks::shouldSilenceWindowResizeEvents() const
{
#if PLATFORM(IOS)
Modified: trunk/Source/WebCore/page/Quirks.h (273441 => 273442)
--- trunk/Source/WebCore/page/Quirks.h 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/page/Quirks.h 2021-02-24 23:02:00 UTC (rev 273442)
@@ -147,6 +147,8 @@
WEBCORE_EXPORT bool shouldBypassUserGestureRequirementForWebAuthn() const;
#endif
+ static bool shouldOmitHTMLDocumentSupportedPropertyNames();
+
private:
bool needsQuirks() const;
Modified: trunk/Source/WebCore/platform/cocoa/VersionChecks.h (273441 => 273442)
--- trunk/Source/WebCore/platform/cocoa/VersionChecks.h 2021-02-24 23:01:23 UTC (rev 273441)
+++ trunk/Source/WebCore/platform/cocoa/VersionChecks.h 2021-02-24 23:02:00 UTC (rev 273442)
@@ -65,6 +65,7 @@
FirstWithWKWebsiteDataStoreInitReturningNil = DYLD_IOS_VERSION_14_0,
FirstVersionWithiOSAppsOnMacOS = DYLD_IOS_VERSION_FIRST_WITH_IOS_APPS_ON_MACOS,
FirstWithDataURLFragmentRemoval = DYLD_IOS_VERSION_14_5,
+ FirstWithHTMLDocumentSupportedPropertyNames = DYLD_IOS_VERSION_14_5,
FirstThatObservesClassProperty = DYLD_IOS_VERSION_14_5,
FirstWithNullOriginForNonSpecialSchemedURLs = DYLD_IOS_VERSION_15_0,
FirstWithoutWeChatScrollingQuirk = DYLD_IOS_VERSION_14_5,
@@ -86,6 +87,7 @@
FirstWithInitializeWebKit2MainThreadAssertion = DYLD_MACOSX_VERSION_10_16,
FirstWithWKWebsiteDataStoreInitReturningNil = DYLD_MACOSX_VERSION_10_16,
FirstWithDataURLFragmentRemoval = DYLD_MACOSX_VERSION_11_3,
+ FirstWithHTMLDocumentSupportedPropertyNames = DYLD_MACOSX_VERSION_11_3,
FirstWithNullOriginForNonSpecialSchemedURLs = DYLD_MACOSX_VERSION_12_00,
#endif
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
