Title: [273961] trunk
- Revision
- 273961
- Author
- commit-qu...@webkit.org
- Date
- 2021-03-05 04:05:02 -0800 (Fri, 05 Mar 2021)
Log Message
XRFrame getViewerPose has emulatedPosition set properly
https://bugs.webkit.org/show_bug.cgi?id=222785
Patch by Imanol Fernandez <ifernan...@igalia.com> on 2021-03-05
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Update getViewerPose_emulatedPosition test expectations.
* web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt: Added.
Source/WebCore:
emulatedPosition in set in WebXR DOM code and OpenXR platform, but not set in FakeWebXRDevice.
Tested by getViewerPose_emulatedPosition.html.
* testing/WebFakeXRDevice.cpp:
(WebCore::SimulatedXRDevice::frameTimerFired): set emulatedPosition
LayoutTests:
Update getViewerPose_emulatedPosition test expectations.
* platform/wpe/TestExpectations:
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (273960 => 273961)
--- trunk/LayoutTests/ChangeLog 2021-03-05 11:53:13 UTC (rev 273960)
+++ trunk/LayoutTests/ChangeLog 2021-03-05 12:05:02 UTC (rev 273961)
@@ -1,3 +1,14 @@
+2021-03-05 Imanol Fernandez <ifernan...@igalia.com>
+
+ XRFrame getViewerPose has emulatedPosition set properly
+ https://bugs.webkit.org/show_bug.cgi?id=222785
+
+ Reviewed by Sergio Villar Senin.
+
+ Update getViewerPose_emulatedPosition test expectations.
+
+ * platform/wpe/TestExpectations:
+
2021-03-03 Sergio Villar Senin <svil...@igalia.com>
[css-flexbox] Fix mainAxisLengthIsDefinite for orthogonal items with percentage sizes
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (273960 => 273961)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-03-05 11:53:13 UTC (rev 273960)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-03-05 12:05:02 UTC (rev 273961)
@@ -1,5 +1,16 @@
2021-03-05 Imanol Fernandez <ifernan...@igalia.com>
+ XRFrame getViewerPose has emulatedPosition set properly
+ https://bugs.webkit.org/show_bug.cgi?id=222785
+
+ Reviewed by Sergio Villar Senin.
+
+ Update getViewerPose_emulatedPosition test expectations.
+
+ * web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt: Added.
+
+2021-03-05 Imanol Fernandez <ifernan...@igalia.com>
+
Implement WebXRBoundedReferenceSpace bounds geometry
https://bugs.webkit.org/show_bug.cgi?id=222737
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt (0 => 273961)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt 2021-03-05 12:05:02 UTC (rev 273961)
@@ -0,0 +1,3 @@
+
+PASS XRFrame getViewerPose has emulatedPosition set properly.
+
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (273960 => 273961)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2021-03-05 11:53:13 UTC (rev 273960)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-03-05 12:05:02 UTC (rev 273961)
@@ -619,6 +619,7 @@
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_no_mode.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_non_immersive_no_gesture.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https.html [ Pass ]
+imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https.html [ Pass ]
imported/w3c/web-platform-tests/webxr/xrFrame_getViewerPose_getPose.https.html [ Pass ]
imported/w3c/web-platform-tests/webxr/xrFrame_getPose.https.html [ Pass ]
imported/w3c/web-platform-tests/webxr/xrFrame_session_sameObject.https.html [ Pass ]
Modified: trunk/Source/WebCore/ChangeLog (273960 => 273961)
--- trunk/Source/WebCore/ChangeLog 2021-03-05 11:53:13 UTC (rev 273960)
+++ trunk/Source/WebCore/ChangeLog 2021-03-05 12:05:02 UTC (rev 273961)
@@ -1,3 +1,17 @@
+2021-03-05 Imanol Fernandez <ifernan...@igalia.com>
+
+ XRFrame getViewerPose has emulatedPosition set properly
+ https://bugs.webkit.org/show_bug.cgi?id=222785
+
+ Reviewed by Sergio Villar Senin.
+
+ emulatedPosition in set in WebXR DOM code and OpenXR platform, but not set in FakeWebXRDevice.
+
+ Tested by getViewerPose_emulatedPosition.html.
+
+ * testing/WebFakeXRDevice.cpp:
+ (WebCore::SimulatedXRDevice::frameTimerFired): set emulatedPosition
+
2021-03-05 Philippe Normand <pnorm...@igalia.com>
Unreviewed, final (hopefully) WPE/GTK follow-up to r273951
Modified: trunk/Source/WebCore/testing/WebFakeXRDevice.cpp (273960 => 273961)
--- trunk/Source/WebCore/testing/WebFakeXRDevice.cpp 2021-03-05 11:53:13 UTC (rev 273960)
+++ trunk/Source/WebCore/testing/WebFakeXRDevice.cpp 2021-03-05 12:05:02 UTC (rev 273961)
@@ -103,6 +103,7 @@
data.origin = *m_viewerOrigin;
data.isTrackingValid = true;
data.isPositionValid = true;
+ data.isPositionEmulated = m_emulatedPosition;
}
if (m_floorOrigin)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
