- Revision
- 274168
- Author
- wei...@apple.com
- Date
- 2021-03-09 12:41:45 -0800 (Tue, 09 Mar 2021)
Log Message
Remove CSSParserContext::enforcesCSSMIMETypeInNoQuirksMode as it is unused
https://bugs.webkit.org/show_bug.cgi?id=222949
Reviewed by Darin Adler.
At some point in the past we stoped doing anything with the enforcesCSSMIMETypeInNoQuirksMode
bit on CSSParserContext.
The only time it was ever disabled was when running ancient versions of iWeb, a product that
itself hasn't existed for over a decade, so I think we are ok to remove it.
Source/WebCore:
* css/parser/CSSParserContext.cpp:
(WebCore::operator==):
* css/parser/CSSParserContext.h:
(WebCore::CSSParserContextHash::hash):
Source/WebKitLegacy/mac:
* WebView/WebPreferencesDefaultValues.h:
* WebView/WebPreferencesDefaultValues.mm:
(WebKit::defaultEnforceCSSMIMETypeInNoQuirksMode): Deleted.
Source/WTF:
* Scripts/Preferences/WebPreferences.yaml:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (274167 => 274168)
--- trunk/Source/WTF/ChangeLog 2021-03-09 20:14:20 UTC (rev 274167)
+++ trunk/Source/WTF/ChangeLog 2021-03-09 20:41:45 UTC (rev 274168)
@@ -1,3 +1,18 @@
+2021-03-09 Sam Weinig <wei...@apple.com>
+
+ Remove CSSParserContext::enforcesCSSMIMETypeInNoQuirksMode as it is unused
+ https://bugs.webkit.org/show_bug.cgi?id=222949
+
+ Reviewed by Darin Adler.
+
+ At some point in the past we stoped doing anything with the enforcesCSSMIMETypeInNoQuirksMode
+ bit on CSSParserContext.
+
+ The only time it was ever disabled was when running ancient versions of iWeb, a product that
+ itself hasn't existed for over a decade, so I think we are ok to remove it.
+
+ * Scripts/Preferences/WebPreferences.yaml:
+
2021-03-09 Ben Nham <n...@apple.com>
Adopt new NSURLSessionConfiguration SPI for connection cache configuration
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (274167 => 274168)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2021-03-09 20:14:20 UTC (rev 274167)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2021-03-09 20:41:45 UTC (rev 274168)
@@ -740,17 +740,6 @@
WebCore:
default: false
-EnforceCSSMIMETypeInNoQuirksMode:
- type: bool
- defaultValue:
- WebKitLegacy:
- PLATFORM(MAC): WebKit::defaultEnforceCSSMIMETypeInNoQuirksMode()
- default: true
- WebKit:
- default: true
- WebCore:
- default: true
-
EnumeratingAllNetworkInterfacesEnabled:
type: bool
webcoreBinding: none
Modified: trunk/Source/WebCore/ChangeLog (274167 => 274168)
--- trunk/Source/WebCore/ChangeLog 2021-03-09 20:14:20 UTC (rev 274167)
+++ trunk/Source/WebCore/ChangeLog 2021-03-09 20:41:45 UTC (rev 274168)
@@ -1,3 +1,21 @@
+2021-03-09 Sam Weinig <wei...@apple.com>
+
+ Remove CSSParserContext::enforcesCSSMIMETypeInNoQuirksMode as it is unused
+ https://bugs.webkit.org/show_bug.cgi?id=222949
+
+ Reviewed by Darin Adler.
+
+ At some point in the past we stoped doing anything with the enforcesCSSMIMETypeInNoQuirksMode
+ bit on CSSParserContext.
+
+ The only time it was ever disabled was when running ancient versions of iWeb, a product that
+ itself hasn't existed for over a decade, so I think we are ok to remove it.
+
+ * css/parser/CSSParserContext.cpp:
+ (WebCore::operator==):
+ * css/parser/CSSParserContext.h:
+ (WebCore::CSSParserContextHash::hash):
+
2021-03-09 Michael Catanzaro <mcatanz...@gnome.org>
[WPE][GTK] Reenable -fvisibility=hidden (and -fvisibility-inlines-hidden for WPE)
Modified: trunk/Source/WebCore/css/parser/CSSParserContext.cpp (274167 => 274168)
--- trunk/Source/WebCore/css/parser/CSSParserContext.cpp 2021-03-09 20:14:20 UTC (rev 274167)
+++ trunk/Source/WebCore/css/parser/CSSParserContext.cpp 2021-03-09 20:41:45 UTC (rev 274168)
@@ -74,7 +74,6 @@
, constantPropertiesEnabled { document.settings().constantPropertiesEnabled() }
, cssColor4 { document.settings().cssColor4() }
, deferredCSSParserEnabled { document.settings().deferredCSSParserEnabled() }
- , enforcesCSSMIMETypeInNoQuirksMode { document.settings().enforceCSSMIMETypeInNoQuirksMode() }
, individualTransformPropertiesEnabled { document.settings().cssIndividualTransformPropertiesEnabled() }
#if ENABLE(OVERFLOW_SCROLLING_TOUCH)
, legacyOverflowScrollingTouchEnabled { shouldEnableLegacyOverflowScrollingTouch(document) }
@@ -114,7 +113,6 @@
&& a.constantPropertiesEnabled == b.constantPropertiesEnabled
&& a.cssColor4 == b.cssColor4
&& a.deferredCSSParserEnabled == b.deferredCSSParserEnabled
- && a.enforcesCSSMIMETypeInNoQuirksMode == b.enforcesCSSMIMETypeInNoQuirksMode
&& a.individualTransformPropertiesEnabled == b.individualTransformPropertiesEnabled
#if ENABLE(OVERFLOW_SCROLLING_TOUCH)
&& a.legacyOverflowScrollingTouchEnabled == b.legacyOverflowScrollingTouchEnabled
Modified: trunk/Source/WebCore/css/parser/CSSParserContext.h (274167 => 274168)
--- trunk/Source/WebCore/css/parser/CSSParserContext.h 2021-03-09 20:14:20 UTC (rev 274167)
+++ trunk/Source/WebCore/css/parser/CSSParserContext.h 2021-03-09 20:41:45 UTC (rev 274168)
@@ -64,7 +64,6 @@
bool constantPropertiesEnabled { false };
bool cssColor4 { false };
bool deferredCSSParserEnabled { false };
- bool enforcesCSSMIMETypeInNoQuirksMode { true };
bool individualTransformPropertiesEnabled { false };
#if ENABLE(OVERFLOW_SCROLLING_TOUCH)
bool legacyOverflowScrollingTouchEnabled { false };
@@ -117,27 +116,26 @@
& key.constantPropertiesEnabled << 8
& key.cssColor4 << 9
& key.deferredCSSParserEnabled << 10
- & key.enforcesCSSMIMETypeInNoQuirksMode << 11
- & key.individualTransformPropertiesEnabled << 12
+ & key.individualTransformPropertiesEnabled << 11
#if ENABLE(OVERFLOW_SCROLLING_TOUCH)
- & key.legacyOverflowScrollingTouchEnabled << 13
+ & key.legacyOverflowScrollingTouchEnabled << 12
#endif
- & key.overscrollBehaviorEnabled << 14
- & key.relativeColorSyntaxEnabled << 15
- & key.scrollBehaviorEnabled << 16
- & key.springTimingFunctionEnabled << 17
+ & key.overscrollBehaviorEnabled << 13
+ & key.relativeColorSyntaxEnabled << 14
+ & key.scrollBehaviorEnabled << 15
+ & key.springTimingFunctionEnabled << 16
#if ENABLE(TEXT_AUTOSIZING)
- & key.textAutosizingEnabled << 18
+ & key.textAutosizingEnabled << 17
#endif
#if ENABLE(CSS_TRANSFORM_STYLE_OPTIMIZED_3D)
- & key.transformStyleOptimized3DEnabled << 19
+ & key.transformStyleOptimized3DEnabled << 18
#endif
- & key.useLegacyBackgroundSizeShorthandBehavior << 20
- & key.focusVisibleEnabled << 21
+ & key.useLegacyBackgroundSizeShorthandBehavior << 19
+ & key.focusVisibleEnabled << 20
#if ENABLE(ATTACHMENT_ELEMENT)
- & key.attachmentEnabled << 22
+ & key.attachmentEnabled << 21
#endif
- & key.mode << 23; // Keep this last.
+ & key.mode << 22; // Keep this last.
hash ^= WTF::intHash(bits);
return hash;
}
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (274167 => 274168)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-03-09 20:14:20 UTC (rev 274167)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-03-09 20:41:45 UTC (rev 274168)
@@ -1,3 +1,20 @@
+2021-03-09 Sam Weinig <wei...@apple.com>
+
+ Remove CSSParserContext::enforcesCSSMIMETypeInNoQuirksMode as it is unused
+ https://bugs.webkit.org/show_bug.cgi?id=222949
+
+ Reviewed by Darin Adler.
+
+ At some point in the past we stoped doing anything with the enforcesCSSMIMETypeInNoQuirksMode
+ bit on CSSParserContext.
+
+ The only time it was ever disabled was when running ancient versions of iWeb, a product that
+ itself hasn't existed for over a decade, so I think we are ok to remove it.
+
+ * WebView/WebPreferencesDefaultValues.h:
+ * WebView/WebPreferencesDefaultValues.mm:
+ (WebKit::defaultEnforceCSSMIMETypeInNoQuirksMode): Deleted.
+
2021-03-09 Wenson Hsieh <wenson_hs...@apple.com>
[macOS] Add a way to trigger webpage translation via the context menu
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h (274167 => 274168)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2021-03-09 20:14:20 UTC (rev 274167)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2021-03-09 20:41:45 UTC (rev 274168)
@@ -71,7 +71,6 @@
bool defaultTreatsAnyTextCSSLinkAsStylesheet();
bool defaultNeedsFrameNameFallbackToIdQuirk();
bool defaultNeedsKeyboardEventDisambiguationQuirks();
-bool defaultEnforceCSSMIMETypeInNoQuirksMode();
#endif
bool defaultAttachmentElementEnabled();
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (274167 => 274168)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2021-03-09 20:14:20 UTC (rev 274167)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2021-03-09 20:41:45 UTC (rev 274168)
@@ -221,12 +221,6 @@
return needsQuirks;
}
-bool defaultEnforceCSSMIMETypeInNoQuirksMode()
-{
- static bool needsQuirk = !_CFAppVersionCheckLessThan(CFSTR("com.apple.iWeb"), -1, 2.1);
- return needsQuirk;
-}
-
#endif // PLATFORM(MAC)
bool defaultAttachmentElementEnabled()
