Title: [274191] trunk/Source/WebKit
- Revision
- 274191
- Author
- bfulg...@apple.com
- Date
- 2021-03-09 18:53:04 -0800 (Tue, 09 Mar 2021)
Log Message
REGRESSION (r274109): Catalina Perf tests failing due to unexpected output (222993)
https://bugs.webkit.org/show_bug.cgi?id=222993
<rdar://75235585>
Reviewed by Alex Christensen.
NSURL generates a single line of console output when we use [NSURL init]. We can avoid hitting this
message by using the preferred default initializer.
Found by existing tests (e.g.: Animation/balls.html)
* Shared/Cocoa/ArgumentCodersCocoa.mm:
(-[WKSecureCodingURLWrapper initWithCoder:]):
(-[WKSecureCodingURLWrapper initWithURL:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (274190 => 274191)
--- trunk/Source/WebKit/ChangeLog 2021-03-10 02:36:50 UTC (rev 274190)
+++ trunk/Source/WebKit/ChangeLog 2021-03-10 02:53:04 UTC (rev 274191)
@@ -1,3 +1,20 @@
+2021-03-09 Brent Fulgham <bfulg...@apple.com>
+
+ REGRESSION (r274109): Catalina Perf tests failing due to unexpected output (222993)
+ https://bugs.webkit.org/show_bug.cgi?id=222993
+ <rdar://75235585>
+
+ Reviewed by Alex Christensen.
+
+ NSURL generates a single line of console output when we use [NSURL init]. We can avoid hitting this
+ message by using the preferred default initializer.
+
+ Found by existing tests (e.g.: Animation/balls.html)
+
+ * Shared/Cocoa/ArgumentCodersCocoa.mm:
+ (-[WKSecureCodingURLWrapper initWithCoder:]):
+ (-[WKSecureCodingURLWrapper initWithURL:]):
+
2021-03-09 Chris Dumez <cdu...@apple.com>
Use UniqueRef<> instead of std::unique_ptr<> when passing IPC::Encoder to sendMessage()
Modified: trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm (274190 => 274191)
--- trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm 2021-03-10 02:36:50 UTC (rev 274190)
+++ trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm 2021-03-10 02:53:04 UTC (rev 274191)
@@ -123,7 +123,7 @@
- (_Nullable instancetype)initWithCoder:(NSCoder *)coder
{
- auto selfPtr = adoptNS([super init]);
+ auto selfPtr = adoptNS([super initWithString:@""]);
if (!selfPtr)
return nil;
@@ -149,7 +149,7 @@
- (_Nullable instancetype)initWithURL:(NSURL *)url
{
- if (self = [super init])
+ if (self = [super initWithString:@""])
m_wrappedURL = url;
return self;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
