Title: [274625] trunk/Source/WebCore
- Revision
- 274625
- Author
- drou...@apple.com
- Date
- 2021-03-18 02:11:13 -0700 (Thu, 18 Mar 2021)
Log Message
should always use all prerequisites for the `ModernMediaControls.{js,css}` rules in DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=223421
Reviewed by Yusuke Suzuki.
* DerivedSources.make:
`$?` is a uniqued space-separated list of all prerequisites modified after the target was modified.
`$^` is a uniqued space-separated list of all prerequisites regardless of when the target/prerequisite was modified.
We want to use the latter since we always want to `cat` all the JS/CSS files, not just the recently edited ones.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (274624 => 274625)
--- trunk/Source/WebCore/ChangeLog 2021-03-18 09:10:35 UTC (rev 274624)
+++ trunk/Source/WebCore/ChangeLog 2021-03-18 09:11:13 UTC (rev 274625)
@@ -1,3 +1,15 @@
+2021-03-18 Devin Rousso <drou...@apple.com>
+
+ should always use all prerequisites for the `ModernMediaControls.{js,css}` rules in DerivedSources.make
+ https://bugs.webkit.org/show_bug.cgi?id=223421
+
+ Reviewed by Yusuke Suzuki.
+
+ * DerivedSources.make:
+ `$?` is a uniqued space-separated list of all prerequisites modified after the target was modified.
+ `$^` is a uniqued space-separated list of all prerequisites regardless of when the target/prerequisite was modified.
+ We want to use the latter since we always want to `cat` all the JS/CSS files, not just the recently edited ones.
+
2021-03-18 Youenn Fablet <you...@apple.com>
RTCRtpScriptTransformer::writable should check for m_backend
Modified: trunk/Source/WebCore/DerivedSources.make (274624 => 274625)
--- trunk/Source/WebCore/DerivedSources.make 2021-03-18 09:10:35 UTC (rev 274624)
+++ trunk/Source/WebCore/DerivedSources.make 2021-03-18 09:11:13 UTC (rev 274625)
@@ -1547,7 +1547,7 @@
all : ModernMediaControls.css
ModernMediaControls.css : $(MODERN_MEDIA_CONTROLS_STYLE_SHEETS)
- cat $? > ModernMediaControls.css
+ cat $^ > ModernMediaControls.css
# user agent style sheets
@@ -1645,7 +1645,7 @@
all : ModernMediaControls.js
ModernMediaControls.js : $(MODERN_MEDIA_CONTROLS_SCRIPTS)
- cat $? > ModernMediaControls.js
+ cat $^ > ModernMediaControls.js
# user agent scripts
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
