Title: [274723] trunk/Source/WebCore
Revision
274723
Author
[email protected]
Date
2021-03-19 09:35:43 -0700 (Fri, 19 Mar 2021)

Log Message

Protect frame before calling didBeginDocument
https://bugs.webkit.org/show_bug.cgi?id=217185

Patch by Rob Buis <[email protected]> on 2021-03-19
Reviewed by Alex Christensen.

Protect frame before calling didBeginDocument
since it could potentially delete the frame
through event handling.

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (274722 => 274723)


--- trunk/Source/WebCore/ChangeLog	2021-03-19 16:25:42 UTC (rev 274722)
+++ trunk/Source/WebCore/ChangeLog	2021-03-19 16:35:43 UTC (rev 274723)
@@ -1,3 +1,17 @@
+2021-03-19  Rob Buis  <[email protected]>
+
+        Protect frame before calling didBeginDocument
+        https://bugs.webkit.org/show_bug.cgi?id=217185
+
+        Reviewed by Alex Christensen.
+
+        Protect frame before calling didBeginDocument
+        since it could potentially delete the frame
+        through event handling.
+
+        * loader/DocumentWriter.cpp:
+        (WebCore::DocumentWriter::begin):
+
 2021-03-19  Xabier Rodriguez Calvar  <[email protected]>
 
         [GStreamer][EME] Remove DRM resources release

Modified: trunk/Source/WebCore/loader/DocumentWriter.cpp (274722 => 274723)


--- trunk/Source/WebCore/loader/DocumentWriter.cpp	2021-03-19 16:25:42 UTC (rev 274722)
+++ trunk/Source/WebCore/loader/DocumentWriter.cpp	2021-03-19 16:35:43 UTC (rev 274723)
@@ -192,6 +192,8 @@
         document->contentSecurityPolicy()->setInsecureNavigationRequestsToUpgrade(existingDocument->contentSecurityPolicy()->takeNavigationRequestsToUpgrade());
     }
 
+    auto protectedFrame = makeRef(*m_frame);
+
     m_frame->loader().didBeginDocument(dispatch);
 
     document->implicitOpen();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to