Title: [105746] trunk/Source/WebKit2
- Revision
- 105746
- Author
- ser...@webkit.org
- Date
- 2012-01-24 10:03:06 -0800 (Tue, 24 Jan 2012)
Log Message
[WK2] [GTK] TestDownloads hitting an assertion in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=76915
Reviewed by Martin Robinson.
No new tests required as it fixes some assertions in a unit test.
* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (105745 => 105746)
--- trunk/Source/WebKit2/ChangeLog 2012-01-24 18:02:08 UTC (rev 105745)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-24 18:03:06 UTC (rev 105746)
@@ -1,3 +1,16 @@
+2012-01-24 Sergio Villar Senin <svil...@igalia.com>
+
+ [WK2] [GTK] TestDownloads hitting an assertion in Debug builds
+ https://bugs.webkit.org/show_bug.cgi?id=76915
+
+ Reviewed by Martin Robinson.
+
+ No new tests required as it fixes some assertions in a unit test.
+
+ * WebProcess/Downloads/soup/DownloadSoup.cpp:
+ (WebKit::Download::start):
+ (WebKit::Download::startWithHandle):
+
2012-01-24 No'am Rosenthal <noam.rosent...@nokia.com>
[Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.
Modified: trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp (105745 => 105746)
--- trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp 2012-01-24 18:02:08 UTC (rev 105745)
+++ trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp 2012-01-24 18:03:06 UTC (rev 105746)
@@ -132,8 +132,8 @@
void Download::start(WebPage* initiatingWebPage)
{
- ASSERT(m_downloadClient);
- ASSERT(m_resourceHandle);
+ ASSERT(!m_downloadClient);
+ ASSERT(!m_resourceHandle);
m_downloadClient = adoptPtr(new DownloadClient(this));
m_resourceHandle = ResourceHandle::create(0, m_request, m_downloadClient.get(), false, false);
didStart();
@@ -141,8 +141,8 @@
void Download::startWithHandle(WebPage* initiatingPage, ResourceHandle* resourceHandle, const ResourceResponse&)
{
- ASSERT(m_downloadClient);
- ASSERT(m_resourceHandle);
+ ASSERT(!m_downloadClient);
+ ASSERT(!m_resourceHandle);
m_downloadClient = adoptPtr(new DownloadClient(this));
resourceHandle->setClient(m_downloadClient.get());
m_resourceHandle = resourceHandle;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
