Title: [275622] trunk/Source/WebKit
- Revision
- 275622
- Author
- [email protected]
- Date
- 2021-04-07 12:31:37 -0700 (Wed, 07 Apr 2021)
Log Message
[Cocoa] Incorrect selector used to set logging level
https://bugs.webkit.org/show_bug.cgi?id=224292
<rdar://problem/75379660>
Reviewed by John Wilander.
The wrong selector label was used to configure the low-level network logging level.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (275621 => 275622)
--- trunk/Source/WebKit/ChangeLog 2021-04-07 19:31:11 UTC (rev 275621)
+++ trunk/Source/WebKit/ChangeLog 2021-04-07 19:31:37 UTC (rev 275622)
@@ -1,3 +1,16 @@
+2021-04-07 Brent Fulgham <[email protected]>
+
+ [Cocoa] Incorrect selector used to set logging level
+ https://bugs.webkit.org/show_bug.cgi?id=224292
+ <rdar://problem/75379660>
+
+ Reviewed by John Wilander.
+
+ The wrong selector label was used to configure the low-level network logging level.
+
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (WebKit::configurationForSessionID):
+
2021-04-07 Alex Christensen <[email protected]>
Use os_transaction_create instead of deprecated xpc_transaction_begin/end
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (275621 => 275622)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-04-07 19:31:11 UTC (rev 275621)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-04-07 19:31:37 UTC (rev 275622)
@@ -1040,9 +1040,11 @@
configuration._shouldSkipPreferredClientCertificateLookup = YES;
#if HAVE(LOGGING_PRIVACY_LEVEL)
- auto setLoggingPrivacyLevel = NSSelectorFromString(@"_setLoggingPrivacyLevel:");
- if ([configuration respondsToSelector:setLoggingPrivacyLevel])
+ auto setLoggingPrivacyLevel = NSSelectorFromString(@"set_loggingPrivacyLevel:");
+ if ([configuration respondsToSelector:setLoggingPrivacyLevel]) {
wtfObjCMsgSend<void>(configuration, setLoggingPrivacyLevel, loggingPrivacyLevel);
+ RELEASE_LOG(NetworkSession, "Setting logging level for %s session %" PRIu64 " to %s", session.isEphemeral() ? "Ephemeral" : "Regular", session.toUInt64(), loggingPrivacyLevel == nw_context_privacy_level_silent ? "silent" : "sensitive");
+ }
#elif HAVE(ALLOWS_SENSITIVE_LOGGING)
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
configuration._allowsSensitiveLogging = NO;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
