Title: [275666] trunk/Tools
- Revision
- 275666
- Author
- [email protected]
- Date
- 2021-04-08 11:30:02 -0700 (Thu, 08 Apr 2021)
Log Message
prepare-ChangeLog fails to find deleted functions in files with spaces in their path in Git repositories
https://bugs.webkit.org/show_bug.cgi?id=224303
Patch by Adam Roben <[email protected]> on 2021-04-08
Reviewed by Sam Weinig.
It would also print a bunch of errors like this on stderr:
fatal: ambiguous argument 'Foo/Bar.cpp': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
* Scripts/prepare-ChangeLog:
(originalFile): Quote the file path in the `git show` command we
construct.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (275665 => 275666)
--- trunk/Tools/ChangeLog 2021-04-08 18:25:13 UTC (rev 275665)
+++ trunk/Tools/ChangeLog 2021-04-08 18:30:02 UTC (rev 275666)
@@ -1,3 +1,20 @@
+2021-04-08 Adam Roben <[email protected]>
+
+ prepare-ChangeLog fails to find deleted functions in files with spaces in their path in Git repositories
+ https://bugs.webkit.org/show_bug.cgi?id=224303
+
+ Reviewed by Sam Weinig.
+
+ It would also print a bunch of errors like this on stderr:
+
+ fatal: ambiguous argument 'Foo/Bar.cpp': unknown revision or path not in the working tree.
+ Use '--' to separate paths from revisions, like this:
+ 'git <command> [<revision>...] -- [<file>...]'
+
+ * Scripts/prepare-ChangeLog:
+ (originalFile): Quote the file path in the `git show` command we
+ construct.
+
2021-04-08 Truitt Savell <[email protected]>
Repalce bot187 with bot178 for CLoop tester.
Modified: trunk/Tools/Scripts/prepare-ChangeLog (275665 => 275666)
--- trunk/Tools/Scripts/prepare-ChangeLog 2021-04-08 18:25:13 UTC (rev 275665)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2021-04-08 18:30:02 UTC (rev 275666)
@@ -270,7 +270,7 @@
} else {
$command .= "HEAD";
}
- $command .= ":$file";
+ $command .= ":'$file'";
}
return $command;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
