Title: [275795] trunk/Tools
- Revision
- 275795
- Author
- aakash_j...@apple.com
- Date
- 2021-04-10 04:20:51 -0700 (Sat, 10 Apr 2021)
Log Message
Improve step description when compile-webkit step is skipped
https://bugs.webkit.org/show_bug.cgi?id=224373
Reviewed by Jonathan Bedard.
* CISupport/ews-build/steps.py:
(CompileWebKit.getResultSummary): Set custom summary when this step is skipped.
* CISupport/ews-build/steps_unittest.py: Updated unit-tests.
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (275794 => 275795)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-04-10 08:39:13 UTC (rev 275794)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-04-10 11:20:51 UTC (rev 275795)
@@ -1595,6 +1595,10 @@
def getResultSummary(self):
if self.results == FAILURE:
return {'step': 'Failed to compile WebKit'}
+ if self.results == SKIPPED:
+ if self.getProperty('fast_commit_queue'):
+ return {'step': 'Skipped compiling WebKit in fast-cq mode'}
+ return {'step': 'Skipped compiling WebKit'}
return shell.Compile.getResultSummary(self)
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (275794 => 275795)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-04-10 08:39:13 UTC (rev 275794)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-04-10 11:20:51 UTC (rev 275795)
@@ -1121,7 +1121,7 @@
self.setProperty('buildername', 'Commit-Queue')
self.setProperty('configuration', 'debug')
self.setProperty('fast_commit_queue', True)
- self.expectOutcome(result=SKIPPED, state_string='Compiled WebKit (skipped)')
+ self.expectOutcome(result=SKIPPED, state_string='Skipped compiling WebKit in fast-cq mode')
return self.runStep()
@@ -1169,7 +1169,7 @@
self.setProperty('fullPlatform', 'ios-simulator-11')
self.setProperty('configuration', 'release')
self.expectHidden(True)
- self.expectOutcome(result=SKIPPED, state_string='Compiled WebKit (skipped)')
+ self.expectOutcome(result=SKIPPED, state_string='Skipped compiling WebKit')
return self.runStep()
Modified: trunk/Tools/ChangeLog (275794 => 275795)
--- trunk/Tools/ChangeLog 2021-04-10 08:39:13 UTC (rev 275794)
+++ trunk/Tools/ChangeLog 2021-04-10 11:20:51 UTC (rev 275795)
@@ -1,3 +1,14 @@
+2021-04-10 Aakash Jain <aakash_j...@apple.com>
+
+ Improve step description when compile-webkit step is skipped
+ https://bugs.webkit.org/show_bug.cgi?id=224373
+
+ Reviewed by Jonathan Bedard.
+
+ * CISupport/ews-build/steps.py:
+ (CompileWebKit.getResultSummary): Set custom summary when this step is skipped.
+ * CISupport/ews-build/steps_unittest.py: Updated unit-tests.
+
2021-04-09 Wenson Hsieh <wenson_hs...@apple.com>
REGRESSION (r271660): Tap highlight no longer shows when tapping clickable elements without touch event listeners
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
