Title: [275877] trunk
- Revision
- 275877
- Author
- [email protected]
- Date
- 2021-04-13 03:26:17 -0700 (Tue, 13 Apr 2021)
Log Message
ASSERTION FAILED: !m_needExceptionCheck in RTCPeerConnection::CertificateParameters
https://bugs.webkit.org/show_bug.cgi?id=223788
Patch by Frédéric Wang <[email protected]> on 2021-04-13
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: js/dom/missing-exception-check-in-convertNumbers.html
* bindings/js/JSDOMConvertNumbers.h:
(WebCore::Converter<IDLFloat>::convert): Handle potential exceptions thrown by toNumber.
(WebCore::Converter<IDLDouble>::convert): Ditto.
LayoutTests:
Add regression test.
* js/dom/missing-exception-check-in-convertNumbers-expected.txt: Added.
* js/dom/missing-exception-check-in-convertNumbers.html: Added.
* platform/win/TestExpectations: Skip test on windows since there is no WebRTC support.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (275876 => 275877)
--- trunk/LayoutTests/ChangeLog 2021-04-13 10:17:38 UTC (rev 275876)
+++ trunk/LayoutTests/ChangeLog 2021-04-13 10:26:17 UTC (rev 275877)
@@ -1,3 +1,16 @@
+2021-04-13 Frédéric Wang <[email protected]>
+
+ ASSERTION FAILED: !m_needExceptionCheck in RTCPeerConnection::CertificateParameters
+ https://bugs.webkit.org/show_bug.cgi?id=223788
+
+ Reviewed by Ryosuke Niwa.
+
+ Add regression test.
+
+ * js/dom/missing-exception-check-in-convertNumbers-expected.txt: Added.
+ * js/dom/missing-exception-check-in-convertNumbers.html: Added.
+ * platform/win/TestExpectations: Skip test on windows since there is no WebRTC support.
+
2021-04-13 Youenn Fablet <[email protected]>
SFrameTransform should be able to take array buffer views as input
Added: trunk/LayoutTests/js/dom/missing-exception-check-in-convertNumbers-expected.txt (0 => 275877)
--- trunk/LayoutTests/js/dom/missing-exception-check-in-convertNumbers-expected.txt (rev 0)
+++ trunk/LayoutTests/js/dom/missing-exception-check-in-convertNumbers-expected.txt 2021-04-13 10:26:17 UTC (rev 275877)
@@ -0,0 +1,4 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/js/dom/missing-exception-check-in-convertNumbers.html (0 => 275877)
--- trunk/LayoutTests/js/dom/missing-exception-check-in-convertNumbers.html (rev 0)
+++ trunk/LayoutTests/js/dom/missing-exception-check-in-convertNumbers.html 2021-04-13 10:26:17 UTC (rev 275877)
@@ -0,0 +1,17 @@
+<!DOCTYPE html><!-- webkit-test-runner [ jscOptions=--validateExceptionChecks=true ] -->
+<html>
+<head>
+<script src=""
+</head>
+<body>
+<script>
+ let handler = {
+ get: Object
+ };
+ let p = new Proxy({}, handler);
+ RTCPeerConnection.generateCertificate(p);
+</script>
+<script src=""
+</body>
+</html>
+
Modified: trunk/LayoutTests/platform/win/TestExpectations (275876 => 275877)
--- trunk/LayoutTests/platform/win/TestExpectations 2021-04-13 10:17:38 UTC (rev 275876)
+++ trunk/LayoutTests/platform/win/TestExpectations 2021-04-13 10:26:17 UTC (rev 275877)
@@ -3665,6 +3665,7 @@
webrtc [ Skip ]
http/tests/webrtc [ Skip ]
http/wpt/webrtc [ Skip ]
+js/dom/missing-exception-check-in-convertNumbers.html [ Skip ]
# Resource Timing Metrics not available.
http/wpt/resource-timing/rt-nextHopProtocol.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (275876 => 275877)
--- trunk/Source/WebCore/ChangeLog 2021-04-13 10:17:38 UTC (rev 275876)
+++ trunk/Source/WebCore/ChangeLog 2021-04-13 10:26:17 UTC (rev 275877)
@@ -1,3 +1,16 @@
+2021-04-13 Frédéric Wang <[email protected]>
+
+ ASSERTION FAILED: !m_needExceptionCheck in RTCPeerConnection::CertificateParameters
+ https://bugs.webkit.org/show_bug.cgi?id=223788
+
+ Reviewed by Ryosuke Niwa.
+
+ Test: js/dom/missing-exception-check-in-convertNumbers.html
+
+ * bindings/js/JSDOMConvertNumbers.h:
+ (WebCore::Converter<IDLFloat>::convert): Handle potential exceptions thrown by toNumber.
+ (WebCore::Converter<IDLDouble>::convert): Ditto.
+
2021-04-13 Rob Buis <[email protected]>
Skip style update
Modified: trunk/Source/WebCore/bindings/js/JSDOMConvertNumbers.h (275876 => 275877)
--- trunk/Source/WebCore/bindings/js/JSDOMConvertNumbers.h 2021-04-13 10:17:38 UTC (rev 275876)
+++ trunk/Source/WebCore/bindings/js/JSDOMConvertNumbers.h 2021-04-13 10:26:17 UTC (rev 275877)
@@ -291,6 +291,7 @@
JSC::VM& vm = JSC::getVM(&lexicalGlobalObject);
auto scope = DECLARE_THROW_SCOPE(vm);
double number = value.toNumber(&lexicalGlobalObject);
+ RETURN_IF_EXCEPTION(scope, 0.0);
if (UNLIKELY(!std::isfinite(number)))
throwNonFiniteTypeError(lexicalGlobalObject, scope);
return static_cast<float>(number);
@@ -346,6 +347,7 @@
JSC::VM& vm = JSC::getVM(&lexicalGlobalObject);
auto scope = DECLARE_THROW_SCOPE(vm);
double number = value.toNumber(&lexicalGlobalObject);
+ RETURN_IF_EXCEPTION(scope, 0.0);
if (UNLIKELY(!std::isfinite(number)))
throwNonFiniteTypeError(lexicalGlobalObject, scope);
return number;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
