Title: [105899] trunk/Tools
- Revision
- 105899
- Author
- toyos...@chromium.org
- Date
- 2012-01-25 10:55:37 -0800 (Wed, 25 Jan 2012)
Log Message
webkitpy: new-run-webkit-websocket is broken
https://bugs.webkit.org/show_bug.cgi?id=76999
Reviewed by Dirk Pranke.
r105674 broke new-run-webkit-websocket, since options.chromium
doesn't exist any more. new-run-webkit-httpd was also broken
and already fixed at r105835.
* Scripts/new-run-webkit-websocketserver:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (105898 => 105899)
--- trunk/Tools/ChangeLog 2012-01-25 18:54:40 UTC (rev 105898)
+++ trunk/Tools/ChangeLog 2012-01-25 18:55:37 UTC (rev 105899)
@@ -1,3 +1,16 @@
+2012-01-25 Takashi Toyoshima <toyos...@chromium.org>
+
+ webkitpy: new-run-webkit-websocket is broken
+ https://bugs.webkit.org/show_bug.cgi?id=76999
+
+ Reviewed by Dirk Pranke.
+
+ r105674 broke new-run-webkit-websocket, since options.chromium
+ doesn't exist any more. new-run-webkit-httpd was also broken
+ and already fixed at r105835.
+ * Scripts/new-run-webkit-websocketserver:
+ (main):
+
2012-01-25 NĂ¡ndor Huszka <huszka.nan...@stud.u-szeged.hu>
[WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
Modified: trunk/Tools/Scripts/new-run-webkit-websocketserver (105898 => 105899)
--- trunk/Tools/Scripts/new-run-webkit-websocketserver 2012-01-25 18:54:40 UTC (rev 105898)
+++ trunk/Tools/Scripts/new-run-webkit-websocketserver 2012-01-25 18:55:37 UTC (rev 105899)
@@ -1,5 +1,5 @@
#!/usr/bin/env python
-# Copyright (C) 2010 Google Inc. All rights reserved.
+# Copyright (C) 2012 Google Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
@@ -92,7 +92,8 @@
kwds['pidfile'] = options.pidfile
host = Host()
- port_obj = host.port_factory.get(options=options)
+ # FIXME: Make this work with other ports as well.
+ port_obj = host.port_factory.get(port_name='chromium', options=options)
pywebsocket = websocket_server.PyWebSocket(port_obj, options.output_dir, **kwds)
log_level = logging.WARN
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes