Title: [276681] trunk/Source/WebInspectorUI
Revision
276681
Author
pan...@apple.com
Date
2021-04-27 17:04:53 -0700 (Tue, 27 Apr 2021)

Log Message

Web Inspector: Rename "Open in New Tab" context menu item to "Open in New Window"
https://bugs.webkit.org/show_bug.cgi?id=225125

Reviewed by BJ Burg.

Update the context menu item label, as the "Open in..." context menu item opens the target item in a new window,
not a new tab.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/ContextMenuUtilities.js:
(WI.appendContextMenuItemsForURL):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (276680 => 276681)


--- trunk/Source/WebInspectorUI/ChangeLog	2021-04-27 23:53:42 UTC (rev 276680)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-04-28 00:04:53 UTC (rev 276681)
@@ -1,5 +1,19 @@
 2021-04-27  Patrick Angle  <pan...@apple.com>
 
+        Web Inspector: Rename "Open in New Tab" context menu item to "Open in New Window"
+        https://bugs.webkit.org/show_bug.cgi?id=225125
+
+        Reviewed by BJ Burg.
+
+        Update the context menu item label, as the "Open in..." context menu item opens the target item in a new window,
+        not a new tab.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/ContextMenuUtilities.js:
+        (WI.appendContextMenuItemsForURL):
+
+2021-04-27  Patrick Angle  <pan...@apple.com>
+
         Web Inspector: Default Audits script are minified in release builds
         https://bugs.webkit.org/show_bug.cgi?id=225009
 

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (276680 => 276681)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2021-04-27 23:53:42 UTC (rev 276680)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2021-04-28 00:04:53 UTC (rev 276681)
@@ -1021,7 +1021,8 @@
 localizedStrings["Only show resources with issues"] = "Only show resources with issues";
 localizedStrings["Only show visual actions"] = "Only show visual actions";
 localizedStrings["Open"] = "Open";
-localizedStrings["Open in New Tab"] = "Open in New Tab";
+/* Context menu item for opening the target item in a new window. */
+localizedStrings["Open in New Window @ Context Menu Item"] = "Open in New Window";
 localizedStrings["Option-click to show source"] = "Option-click to show source";
 localizedStrings["Options"] = "Options";
 /* Property value for `font-variant-numeric: ordinal`. */

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js (276680 => 276681)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js	2021-04-27 23:53:42 UTC (rev 276680)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js	2021-04-28 00:04:53 UTC (rev 276681)
@@ -212,7 +212,7 @@
     }
 
     if (!url.startsWith("_javascript_:") && !url.startsWith("data:")) {
-        contextMenu.appendItem(WI.UIString("Open in New Tab"), () => {
+        contextMenu.appendItem(WI.UIString("Open in New Window", "Open in New Window @ Context Menu Item", "Context menu item for opening the target item in a new window."), () => {
             const frame = null;
             WI.openURL(url, frame, {alwaysOpenExternally: true});
         });
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to