Title: [276838] trunk/Source/WebKit
- Revision
- 276838
- Author
- bfulg...@apple.com
- Date
- 2021-04-30 08:15:38 -0700 (Fri, 30 Apr 2021)
Log Message
[Cocoa] Always extend access to local process HTTP/3 cache directory
https://bugs.webkit.org/show_bug.cgi?id=225171
<rdar://problem/76287224>
Reviewed by Alex Christensen.
Always pass the cache directory for HTTP/3 use, regardless of the current setting of
the flag. We still pass the flag so that users can turn the feature on and off, so there
is no change in expected behavior. However, certain OS settings can override the user
setting in the browser, so it's helpful to have the path permission for cases where a user
toggles state outside of the browser.
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276837 => 276838)
--- trunk/Source/WebKit/ChangeLog 2021-04-30 14:24:32 UTC (rev 276837)
+++ trunk/Source/WebKit/ChangeLog 2021-04-30 15:15:38 UTC (rev 276838)
@@ -1,3 +1,20 @@
+2021-04-30 Brent Fulgham <bfulg...@apple.com>
+
+ [Cocoa] Always extend access to local process HTTP/3 cache directory
+ https://bugs.webkit.org/show_bug.cgi?id=225171
+ <rdar://problem/76287224>
+
+ Reviewed by Alex Christensen.
+
+ Always pass the cache directory for HTTP/3 use, regardless of the current setting of
+ the flag. We still pass the flag so that users can turn the feature on and off, so there
+ is no change in expected behavior. However, certain OS settings can override the user
+ setting in the browser, so it's helpful to have the path permission for cases where a user
+ toggles state outside of the browser.
+
+ * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
+ (WebKit::WebsiteDataStore::platformSetNetworkParameters):
+
2021-04-29 Megan Gardner <megan_gard...@apple.com>
Remove some unneeded code.
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm (276837 => 276838)
--- trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm 2021-04-30 14:24:32 UTC (rev 276837)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm 2021-04-30 15:15:38 UTC (rev 276838)
@@ -153,13 +153,10 @@
#if HAVE(CFNETWORK_ALTERNATIVE_SERVICE)
bool http3Enabled = WebsiteDataStore::http3Enabled();
- String alternativeServiceStorageDirectory;
SandboxExtension::Handle alternativeServiceStorageDirectoryExtensionHandle;
- if (http3Enabled) {
- alternativeServiceStorageDirectory = resolvedAlternativeServicesStorageDirectory();
- if (!alternativeServiceStorageDirectory.isEmpty())
- SandboxExtension::createHandleForReadWriteDirectory(alternativeServiceStorageDirectory, alternativeServiceStorageDirectoryExtensionHandle);
- }
+ String alternativeServiceStorageDirectory = resolvedAlternativeServicesStorageDirectory();
+ if (!alternativeServiceStorageDirectory.isEmpty())
+ SandboxExtension::createHandleForReadWriteDirectory(alternativeServiceStorageDirectory, alternativeServiceStorageDirectoryExtensionHandle);
#endif
bool shouldIncludeLocalhostInResourceLoadStatistics = isSafari;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
