Title: [105968] trunk
- Revision
- 105968
- Author
- commit-qu...@webkit.org
- Date
- 2012-01-26 00:06:16 -0800 (Thu, 26 Jan 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.
As per the HTML spec http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#dom-input-indeterminate,
only checkbox input type should respect the indeterminate state.
Removed the support for indeterminate state for radio input types.
Source/WebCore:
Patch by Joe Thomas <joetho...@motorola.com> on 2012-01-26
Reviewed by Eric Seidel.
Modified the existing test cases.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setIndeterminate): Indeterminate state is supported only for checkbox input type.
LayoutTests:
Modified the existing test cases.
Patch by Joe Thomas <joetho...@motorola.com> on 2012-01-26
Reviewed by Eric Seidel.
* fast/forms/indeterminate-radio.html:
* fast/forms/radio-checkbox-restore-indeterminate.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (105967 => 105968)
--- trunk/LayoutTests/ChangeLog 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/LayoutTests/ChangeLog 2012-01-26 08:06:16 UTC (rev 105968)
@@ -1,3 +1,19 @@
+2012-01-26 Joe Thomas <joetho...@motorola.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=76995.
+ WebKit fails IETC :indeterminate and input type=radio test.
+
+ As per the HTML spec http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#dom-input-indeterminate,
+ only checkbox input type should respect the indeterminate state.
+ Removed the support for indeterminate state for radio input types.
+
+ Modified the existing test cases.
+
+ Reviewed by Eric Seidel.
+
+ * fast/forms/indeterminate-radio.html:
+ * fast/forms/radio-checkbox-restore-indeterminate.html:
+
2012-01-25 Levi Weintraub <le...@chromium.org>
Layout Test fast/js/dfg-uint32array-overflow-values.html is slow on Chromium Debug bots
Modified: trunk/LayoutTests/fast/forms/indeterminate-radio.html (105967 => 105968)
--- trunk/LayoutTests/fast/forms/indeterminate-radio.html 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/LayoutTests/fast/forms/indeterminate-radio.html 2012-01-26 08:06:16 UTC (rev 105968)
@@ -5,11 +5,11 @@
<style type="text/css">
div
{
- color: red;
+ color: green;
}
input:indeterminate + #test
{
- color: green;
+ color: red;
}
</style>
</head>
Modified: trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html (105967 => 105968)
--- trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html 2012-01-26 08:06:16 UTC (rev 105968)
@@ -67,8 +67,8 @@
log('Click unselected all radio buttons: FAIL');
log('<br>Checking whether default-prevented click clobbered indeterminate state:')
- log('On checked radio button: ' + (radio3.indeterminate ? 'PASS' : 'FAIL'));
- log('On unchecked radio button: ' + (radio4.indeterminate ? 'PASS' : 'FAIL'));
+ log('On checked radio button: ' + (!radio3.indeterminate ? 'PASS' : 'FAIL'));
+ log('On unchecked radio button: ' + (!radio4.indeterminate ? 'PASS' : 'FAIL'));
log('On checked checkbox: ' + (check1.indeterminate ? 'PASS' : 'FAIL'));
log('On unchecked checkbox: ' + (check2.indeterminate ? 'PASS' : 'FAIL'));
Modified: trunk/Source/WebCore/ChangeLog (105967 => 105968)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 08:06:16 UTC (rev 105968)
@@ -1,3 +1,19 @@
+2012-01-26 Joe Thomas <joetho...@motorola.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=76995.
+ WebKit fails IETC :indeterminate and input type=radio test.
+
+ As per the HTML spec http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#dom-input-indeterminate,
+ only checkbox input type should respect the indeterminate state.
+ Removed the support for indeterminate state for radio input types.
+
+ Reviewed by Eric Seidel.
+
+ Modified the existing test cases.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setIndeterminate): Indeterminate state is supported only for checkbox input type.
+
2012-01-25 Daniel Cheng <dch...@chromium.org>
[chromium] Fix ClipboardChromium::validateFilename to actually operate on extensions
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (105967 => 105968)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2012-01-26 08:06:16 UTC (rev 105968)
@@ -946,7 +946,7 @@
void HTMLInputElement::setIndeterminate(bool newValue)
{
- if (!m_inputType->isCheckable() || indeterminate() == newValue)
+ if (!isCheckbox() || indeterminate() == newValue)
return;
m_isIndeterminate = newValue;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
