Title: [106012] trunk/Source/WebKit2
- Revision
- 106012
- Author
- abe...@webkit.org
- Date
- 2012-01-26 10:46:55 -0800 (Thu, 26 Jan 2012)
Log Message
ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
https://bugs.webkit.org/show_bug.cgi?id=77117
Reviewed by Tor Arne Vestbø.
The PageOverlay does only get uninstalled after the fade-out animation finishes,
so do not assert on !m_overlay after the uninstallPageOverlay call.
* WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::hideHighlight):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (106011 => 106012)
--- trunk/Source/WebKit2/ChangeLog 2012-01-26 18:45:10 UTC (rev 106011)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-26 18:46:55 UTC (rev 106012)
@@ -1,3 +1,16 @@
+2012-01-26 Andras Becsi <andras.be...@nokia.com>
+
+ ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
+ https://bugs.webkit.org/show_bug.cgi?id=77117
+
+ Reviewed by Tor Arne Vestbø.
+
+ The PageOverlay does only get uninstalled after the fade-out animation finishes,
+ so do not assert on !m_overlay after the uninstallPageOverlay call.
+
+ * WebProcess/WebPage/TapHighlightController.cpp:
+ (WebKit::TapHighlightController::hideHighlight):
+
2012-01-26 Caio Marcelo de Oliveira Filho <caio.olive...@openbossa.org>
WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
Modified: trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp (106011 => 106012)
--- trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp 2012-01-26 18:45:10 UTC (rev 106011)
+++ trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp 2012-01-26 18:46:55 UTC (rev 106012)
@@ -70,7 +70,6 @@
{
if (m_overlay)
m_webPage->uninstallPageOverlay(m_overlay, /* fadeout */ true);
- ASSERT(!m_overlay);
}
void TapHighlightController::pageOverlayDestroyed(PageOverlay*)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes