Title: [278031] trunk/Source/WebCore
- Revision
- 278031
- Author
- simon.fra...@apple.com
- Date
- 2021-05-25 11:26:49 -0700 (Tue, 25 May 2021)
Log Message
Divide by zero in DisplayUpdate::relevantForUpdateFrequency()
https://bugs.webkit.org/show_bug.cgi?id=226224
<rdar://76894675>
Reviewed by Wenson Hsieh.
Check for non-zero preferredFramesPerSecond before using it as a denominator
to avoid divide by zero.
* platform/graphics/DisplayUpdate.cpp:
(WebCore::DisplayUpdate::relevantForUpdateFrequency const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (278030 => 278031)
--- trunk/Source/WebCore/ChangeLog 2021-05-25 18:16:47 UTC (rev 278030)
+++ trunk/Source/WebCore/ChangeLog 2021-05-25 18:26:49 UTC (rev 278031)
@@ -1,3 +1,17 @@
+2021-05-25 Simon Fraser <simon.fra...@apple.com>
+
+ Divide by zero in DisplayUpdate::relevantForUpdateFrequency()
+ https://bugs.webkit.org/show_bug.cgi?id=226224
+ <rdar://76894675>
+
+ Reviewed by Wenson Hsieh.
+
+ Check for non-zero preferredFramesPerSecond before using it as a denominator
+ to avoid divide by zero.
+
+ * platform/graphics/DisplayUpdate.cpp:
+ (WebCore::DisplayUpdate::relevantForUpdateFrequency const):
+
2021-05-25 Alan Bujtas <za...@apple.com>
CrashOnOverflow in WebCore::RenderTable::cellBefore(WebCore::RenderTableCell const*)
Modified: trunk/Source/WebCore/platform/graphics/DisplayUpdate.cpp (278030 => 278031)
--- trunk/Source/WebCore/platform/graphics/DisplayUpdate.cpp 2021-05-25 18:16:47 UTC (rev 278030)
+++ trunk/Source/WebCore/platform/graphics/DisplayUpdate.cpp 2021-05-25 18:26:49 UTC (rev 278031)
@@ -35,7 +35,7 @@
bool DisplayUpdate::relevantForUpdateFrequency(FramesPerSecond preferredFramesPerSecond) const
{
// FIXME: Ideally this would be an assertion, but that may fire when windows move between screens with different refresh rates, because of webkit.org/b/212120.
- if (!WTF::isIntegral(static_cast<float>(updatesPerSecond) / preferredFramesPerSecond || !preferredFramesPerSecond))
+ if (!preferredFramesPerSecond || !WTF::isIntegral(static_cast<float>(updatesPerSecond) / preferredFramesPerSecond))
return true;
unsigned rateFactor = updatesPerSecond / preferredFramesPerSecond;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
