Title: [278127] trunk/Tools
- Revision
- 278127
- Author
- jbed...@apple.com
- Date
- 2021-05-26 15:08:05 -0700 (Wed, 26 May 2021)
Log Message
[webkitpy] Refactor SimulatorDevice (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=225158
Unreviewed follow-up fix.
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.is_usable): When no UI Manager service is defined, we should early exit.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (278126 => 278127)
--- trunk/Tools/ChangeLog 2021-05-26 21:34:41 UTC (rev 278126)
+++ trunk/Tools/ChangeLog 2021-05-26 22:08:05 UTC (rev 278127)
@@ -1,3 +1,13 @@
+2021-05-26 Jonathan Bedard <jbed...@apple.com>
+
+ [webkitpy] Refactor SimulatorDevice (Follow-up fix)
+ https://bugs.webkit.org/show_bug.cgi?id=225158
+
+ Unreviewed follow-up fix.
+
+ * Scripts/webkitpy/xcode/simulated_device.py:
+ (SimulatedDevice.is_usable): When no UI Manager service is defined, we should early exit.
+
2021-05-26 Aakash Jain <aakash_j...@apple.com>
Do not skip SetCommitQueueMinusFlagOnPatch step on EWS test instances
Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py (278126 => 278127)
--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py 2021-05-26 21:34:41 UTC (rev 278126)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py 2021-05-26 22:08:05 UTC (rev 278127)
@@ -579,7 +579,7 @@
return False
service = self.UI_MANAGER_SERVICE.get(self.device_type.software_variant)
- if service:
+ if not service:
_log.debug(u'{} has no service to check if the device is usable'.format(self.device_type.software_variant))
return True
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
