Diff
Modified: trunk/LayoutTests/ChangeLog (278244 => 278245)
--- trunk/LayoutTests/ChangeLog 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/ChangeLog 2021-05-29 23:29:26 UTC (rev 278245)
@@ -1,3 +1,20 @@
+2021-05-29 Cameron McCormack <hey...@apple.com>
+
+ Rename Internals.mainThreadScrollingReasons to synchronousScrollingReasons
+ https://bugs.webkit.org/show_bug.cgi?id=226415
+
+ Reviewed by Simon Fraser.
+
+ * compositing/layer-creation/fixed-position-in-view-dynamic.html:
+ * compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt:
+ * compositing/layer-creation/fixed-position-no-content-scroll-reason.html:
+ * compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
+ * compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
+ * compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
+ * tiled-drawing/scrolling/slow-scrolling-background-toggle.html:
+ * tiled-drawing/scrolling/slow-scrolling-hidden-background-toggle.html:
+ * tiled-drawing/scrolling/slow-scrolling.html:
+
2021-05-29 Zalan Bujtas <za...@apple.com>
[LFC][TFC] Do not include vertical spacing when resolving percent height for table content
Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic.html (278244 => 278245)
--- trunk/LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic.html 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic.html 2021-05-29 23:29:26 UTC (rev 278245)
@@ -22,8 +22,8 @@
document.body.appendChild(fixed);
document.body.offsetHeight;
fixed.className = "fixed";
- var mainThreadScrollingReasons = internals.mainThreadScrollingReasons();
- document.getElementById("result").innerText = !mainThreadScrollingReasons ? "PASS" : "FAIL: " + mainThreadScrollingReasons;
+ var synchronousScrollingReasons = internals.synchronousScrollingReasons();
+ document.getElementById("result").innerText = !synchronousScrollingReasons ? "PASS" : "FAIL: " + synchronousScrollingReasons;
}, false);
}
</script>
Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt (278244 => 278245)
--- trunk/LayoutTests/compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt 2021-05-29 23:29:26 UTC (rev 278245)
@@ -1,2 +1,2 @@
-Main thread scrolling reasons should be blank:
+Synchronous scrolling reasons should be blank:
Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-no-content-scroll-reason.html (278244 => 278245)
--- trunk/LayoutTests/compositing/layer-creation/fixed-position-no-content-scroll-reason.html 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-no-content-scroll-reason.html 2021-05-29 23:29:26 UTC (rev 278245)
@@ -21,7 +21,7 @@
testRunner.dumpAsText();
window.addEventListener("load", function() {
- document.getElementById("mainThreadScrollingReasons").innerText = window.internals.mainThreadScrollingReasons();
+ document.getElementById("synchronousScrollingReasons").innerText = window.internals.synchronousScrollingReasons();
}, false);
}
</script>
@@ -29,8 +29,8 @@
<body>
<div style="height: 1000px">
- Main thread scrolling reasons should be blank:
- <pre id="mainThreadScrollingReasons"></pre>
+ Synchronous scrolling reasons should be blank:
+ <pre id="synchronousScrollingReasons"></pre>
</div>
<div class="fixed"></div>
</body>
Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic.html (278244 => 278245)
--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic.html 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic.html 2021-05-29 23:29:26 UTC (rev 278245)
@@ -22,8 +22,8 @@
document.body.appendChild(fixed);
document.body.offsetHeight;
fixed.className = "fixed";
- var mainThreadScrollingReasons = internals.mainThreadScrollingReasons();
- document.getElementById("result").innerText = !mainThreadScrollingReasons ? "PASS" : "FAIL: " + mainThreadScrollingReasons;
+ var synchronousScrollingReasons = internals.synchronousScrollingReasons();
+ document.getElementById("result").innerText = !synchronousScrollingReasons ? "PASS" : "FAIL: " + synchronousScrollingReasons;
testRunner.notifyDone();
}, false);
}
Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html (278244 => 278245)
--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html 2021-05-29 23:29:26 UTC (rev 278245)
@@ -20,7 +20,7 @@
testRunner.dumpAsText();
window.addEventListener("load", function() {
- document.getElementById("mainThreadScrollingReasons").innerText = window.internals.mainThreadScrollingReasons();
+ document.getElementById("synchronousScrollingReasons").innerText = window.internals.synchronousScrollingReasons();
}, false);
}
</script>
@@ -29,7 +29,7 @@
<body>
<div style="height: 1000px">
Main thread scrolling reasons should be blank:
- <pre id="mainThreadScrollingReasons"></pre>
+ <pre id="synchronousScrollingReasons"></pre>
</div>
<!-- out of view fixed position elements should not trigger main thread scrolling. -->
Modified: trunk/LayoutTests/compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html (278244 => 278245)
--- trunk/LayoutTests/compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html 2021-05-29 23:29:26 UTC (rev 278245)
@@ -23,7 +23,7 @@
window.addEventListener("load", function() {
document.getElementById("layerTree").innerText = window.internals.layerTreeAsText(document);
- document.getElementById("mainThreadScrollingReasons").innerText = window.internals.mainThreadScrollingReasons();
+ document.getElementById("synchronousScrollingReasons").innerText = window.internals.synchronousScrollingReasons();
}, false);
}
</script>
@@ -36,6 +36,6 @@
</div>
<pre id="layerTree"></pre>
- <pre id="mainThreadScrollingReasons"></pre>
+ <pre id="synchronousScrollingReasons"></pre>
</body>
</html>
Modified: trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling-background-toggle.html (278244 => 278245)
--- trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling-background-toggle.html 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling-background-toggle.html 2021-05-29 23:29:26 UTC (rev 278245)
@@ -34,7 +34,7 @@
box.classList.add('loaded');
if (window.internals)
- document.getElementById('reasons').textContent = window.internals.mainThreadScrollingReasons();
+ document.getElementById('reasons').textContent = window.internals.synchronousScrollingReasons();
}
window.addEventListener('load', doTest, false);
</script>
Modified: trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling-hidden-background-toggle.html (278244 => 278245)
--- trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling-hidden-background-toggle.html 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling-hidden-background-toggle.html 2021-05-29 23:29:26 UTC (rev 278245)
@@ -42,7 +42,7 @@
box.classList.add('loaded');
if (window.internals)
- document.getElementById('reasons').textContent = window.internals.mainThreadScrollingReasons();
+ document.getElementById('reasons').textContent = window.internals.synchronousScrollingReasons();
}
window.addEventListener('load', doTest, false);
</script>
Modified: trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling.html (278244 => 278245)
--- trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling.html 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/LayoutTests/tiled-drawing/scrolling/slow-scrolling.html 2021-05-29 23:29:26 UTC (rev 278245)
@@ -27,7 +27,7 @@
function doTest()
{
if (window.internals)
- document.getElementById('reasons').textContent = window.internals.mainThreadScrollingReasons();
+ document.getElementById('reasons').textContent = window.internals.synchronousScrollingReasons();
}
window.addEventListener('load', doTest, false);
</script>
Modified: trunk/Source/WebCore/ChangeLog (278244 => 278245)
--- trunk/Source/WebCore/ChangeLog 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/Source/WebCore/ChangeLog 2021-05-29 23:29:26 UTC (rev 278245)
@@ -1,3 +1,17 @@
+2021-05-29 Cameron McCormack <hey...@apple.com>
+
+ Rename Internals.mainThreadScrollingReasons to synchronousScrollingReasons
+ https://bugs.webkit.org/show_bug.cgi?id=226415
+
+ Reviewed by Simon Fraser.
+
+ Brings the name into accordance with the term the C++ code uses.
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::synchronousScrollingReasons const):
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
2021-05-28 Darin Adler <da...@apple.com>
Clients of optional should use has_value instead of relying on hasValue macro
Modified: trunk/Source/WebCore/testing/Internals.cpp (278244 => 278245)
--- trunk/Source/WebCore/testing/Internals.cpp 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/Source/WebCore/testing/Internals.cpp 2021-05-29 23:29:26 UTC (rev 278245)
@@ -3009,7 +3009,7 @@
return scrollingCoordinator->scrollingTreeAsText();
}
-ExceptionOr<String> Internals::mainThreadScrollingReasons() const
+ExceptionOr<String> Internals::synchronousScrollingReasons() const
{
Document* document = contextDocument();
if (!document || !document->frame())
Modified: trunk/Source/WebCore/testing/Internals.h (278244 => 278245)
--- trunk/Source/WebCore/testing/Internals.h 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/Source/WebCore/testing/Internals.h 2021-05-29 23:29:26 UTC (rev 278245)
@@ -436,7 +436,7 @@
ExceptionOr<String> scrollingStateTreeAsText() const;
ExceptionOr<String> scrollingTreeAsText() const;
- ExceptionOr<String> mainThreadScrollingReasons() const;
+ ExceptionOr<String> synchronousScrollingReasons() const;
ExceptionOr<Ref<DOMRectList>> nonFastScrollableRects() const;
ExceptionOr<void> setElementUsesDisplayListDrawing(Element&, bool usesDisplayListDrawing);
Modified: trunk/Source/WebCore/testing/Internals.idl (278244 => 278245)
--- trunk/Source/WebCore/testing/Internals.idl 2021-05-29 22:08:56 UTC (rev 278244)
+++ trunk/Source/WebCore/testing/Internals.idl 2021-05-29 23:29:26 UTC (rev 278245)
@@ -522,7 +522,7 @@
DOMString scrollingStateTreeAsText();
DOMString scrollingTreeAsText();
- DOMString mainThreadScrollingReasons(); // FIXME: rename to synchronousScrollingReasons().
+ DOMString synchronousScrollingReasons();
DOMRectList nonFastScrollableRects();
DOMString repaintRectsAsText();
