Title: [278270] trunk/Source/WebCore
- Revision
- 278270
- Author
- you...@apple.com
- Date
- 2021-05-30 23:20:28 -0700 (Sun, 30 May 2021)
Log Message
Add logging to allow relating a HTMLMediaElement to a MediaStream
https://bugs.webkit.org/show_bug.cgi?id=226373
Reviewed by Eric Carlson.
Update logging to print the ID of the MediaStream being played by the HTMLMediaElement.
* Modules/mediastream/MediaStream.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (278269 => 278270)
--- trunk/Source/WebCore/ChangeLog 2021-05-31 04:22:39 UTC (rev 278269)
+++ trunk/Source/WebCore/ChangeLog 2021-05-31 06:20:28 UTC (rev 278270)
@@ -1,3 +1,16 @@
+2021-05-30 Youenn Fablet <you...@apple.com>
+
+ Add logging to allow relating a HTMLMediaElement to a MediaStream
+ https://bugs.webkit.org/show_bug.cgi?id=226373
+
+ Reviewed by Eric Carlson.
+
+ Update logging to print the ID of the MediaStream being played by the HTMLMediaElement.
+
+ * Modules/mediastream/MediaStream.h:
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::loadResource):
+
2021-05-30 Sam Weinig <wei...@apple.com>
Use SortedArrayMap in parseColorContrastFunctionParameters
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.h (278269 => 278270)
--- trunk/Source/WebCore/Modules/mediastream/MediaStream.h 2021-05-31 04:22:39 UTC (rev 278269)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.h 2021-05-31 06:20:28 UTC (rev 278270)
@@ -94,6 +94,10 @@
Document* document() const;
+#if !RELEASE_LOG_DISABLED
+ const void* logIdentifier() const final { return m_private->logIdentifier(); }
+#endif
+
protected:
MediaStream(Document&, const MediaStreamTrackVector&);
MediaStream(Document&, Ref<MediaStreamPrivate>&&);
@@ -100,7 +104,6 @@
#if !RELEASE_LOG_DISABLED
const Logger& logger() const final { return m_private->logger(); }
- const void* logIdentifier() const final { return m_private->logIdentifier(); }
WTFLogChannel& logChannel() const final;
const char* logClassName() const final { return "MediaStream"; }
#endif
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (278269 => 278270)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-05-31 04:22:39 UTC (rev 278269)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-05-31 06:20:28 UTC (rev 278270)
@@ -1536,7 +1536,7 @@
#if ENABLE(MEDIA_STREAM)
if (!loadAttempted && m_mediaStreamSrcObject) {
loadAttempted = true;
- ALWAYS_LOG(LOGIDENTIFIER, "loading media stream blob");
+ ALWAYS_LOG(LOGIDENTIFIER, "loading media stream blob ", m_mediaStreamSrcObject->logIdentifier());
if (!m_player->load(m_mediaStreamSrcObject->privateStream()))
mediaLoadingFailed(MediaPlayer::NetworkState::FormatError);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
