Title: [278524] trunk
- Revision
- 278524
- Author
- hey...@apple.com
- Date
- 2021-06-05 00:28:13 -0700 (Sat, 05 Jun 2021)
Log Message
Diff aspect-ratio property values correctly
https://bugs.webkit.org/show_bug.cgi?id=226673
Reviewed by Rob Buis.
Source/WebCore:
Test: fast/css/aspect-ratio-no-relayout.html
* rendering/style/RenderStyle.cpp:
(WebCore::rareNonInheritedDataChangeRequiresLayout):
LayoutTests:
* fast/css/aspect-ratio-no-relayout-expected.txt: Added.
* fast/css/aspect-ratio-no-relayout.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (278523 => 278524)
--- trunk/LayoutTests/ChangeLog 2021-06-05 05:45:56 UTC (rev 278523)
+++ trunk/LayoutTests/ChangeLog 2021-06-05 07:28:13 UTC (rev 278524)
@@ -1,3 +1,13 @@
+2021-06-05 Cameron McCormack <hey...@apple.com>
+
+ Diff aspect-ratio property values correctly
+ https://bugs.webkit.org/show_bug.cgi?id=226673
+
+ Reviewed by Rob Buis.
+
+ * fast/css/aspect-ratio-no-relayout-expected.txt: Added.
+ * fast/css/aspect-ratio-no-relayout.html: Added.
+
2021-06-04 Chris Dumez <cdu...@apple.com>
Worker.constructor throws an exception when the url param is an empty string
Added: trunk/LayoutTests/fast/css/aspect-ratio-no-relayout-expected.txt (0 => 278524)
--- trunk/LayoutTests/fast/css/aspect-ratio-no-relayout-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/aspect-ratio-no-relayout-expected.txt 2021-06-05 07:28:13 UTC (rev 278524)
@@ -0,0 +1,2 @@
+Layout count: 0
+
Added: trunk/LayoutTests/fast/css/aspect-ratio-no-relayout.html (0 => 278524)
--- trunk/LayoutTests/fast/css/aspect-ratio-no-relayout.html (rev 0)
+++ trunk/LayoutTests/fast/css/aspect-ratio-no-relayout.html 2021-06-05 07:28:13 UTC (rev 278524)
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<pre id=log></pre>
+<div id=target style="aspect-ratio: 1 / 2;"></div>
+<script>
+if (window.testRunner && window.internals) {
+ testRunner.dumpAsText();
+ document.body.offsetTop;
+ const layoutCountBefore = internals.layoutCount;
+ target.style.color = "blue";
+ document.body.offsetTop;
+ log.textContent = `Layout count: ${internals.layoutCount - layoutCountBefore}`;
+}
+</script>
Modified: trunk/Source/WebCore/ChangeLog (278523 => 278524)
--- trunk/Source/WebCore/ChangeLog 2021-06-05 05:45:56 UTC (rev 278523)
+++ trunk/Source/WebCore/ChangeLog 2021-06-05 07:28:13 UTC (rev 278524)
@@ -1,3 +1,15 @@
+2021-06-05 Cameron McCormack <hey...@apple.com>
+
+ Diff aspect-ratio property values correctly
+ https://bugs.webkit.org/show_bug.cgi?id=226673
+
+ Reviewed by Rob Buis.
+
+ Test: fast/css/aspect-ratio-no-relayout.html
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::rareNonInheritedDataChangeRequiresLayout):
+
2021-06-04 Chris Dumez <cdu...@apple.com>
Optimize a few call sites creating SharedBuffer objects
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (278523 => 278524)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2021-06-05 05:45:56 UTC (rev 278523)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2021-06-05 07:28:13 UTC (rev 278524)
@@ -737,8 +737,11 @@
return true;
#endif
- if (first.aspectRatioType != second.aspectRatioType || first.aspectRatioWidth != second.aspectRatioWidth || first.aspectRatioWidth != second.aspectRatioHeight)
+ if (first.aspectRatioType != second.aspectRatioType
+ || first.aspectRatioWidth != second.aspectRatioWidth
+ || first.aspectRatioHeight != second.aspectRatioHeight) {
return true;
+ }
return false;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
