Title: [278563] trunk/Source/WebCore
- Revision
- 278563
- Author
- ifernan...@igalia.com
- Date
- 2021-06-07 10:00:31 -0700 (Mon, 07 Jun 2021)
Log Message
Change WebXRSpace::efectiveOrigin() matrix multiplication order
https://bugs.webkit.org/show_bug.cgi?id=224364
<rdar://problem/76754680>
Reviewed by Sergio Villar Senin.
The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace().
The reference space is out of sync with input ray pose after some teleportations:
https://github.com/immersive-web/webxr-samples/blob/main/teleportation.html
Tested using WebXR WPT tests.
* Modules/webxr/WebXRSpace.cpp:
(WebCore::WebXRSpace::effectiveOrigin const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (278562 => 278563)
--- trunk/Source/WebCore/ChangeLog 2021-06-07 15:37:54 UTC (rev 278562)
+++ trunk/Source/WebCore/ChangeLog 2021-06-07 17:00:31 UTC (rev 278563)
@@ -1,5 +1,22 @@
2021-06-07 Imanol Fernandez <ifernan...@igalia.com>
+ Change WebXRSpace::efectiveOrigin() matrix multiplication order
+ https://bugs.webkit.org/show_bug.cgi?id=224364
+ <rdar://problem/76754680>
+
+ Reviewed by Sergio Villar Senin.
+
+ The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace().
+ The reference space is out of sync with input ray pose after some teleportations:
+ https://github.com/immersive-web/webxr-samples/blob/main/teleportation.html
+
+ Tested using WebXR WPT tests.
+
+ * Modules/webxr/WebXRSpace.cpp:
+ (WebCore::WebXRSpace::effectiveOrigin const):
+
+2021-06-07 Imanol Fernandez <ifernan...@igalia.com>
+
Use 3D points to map the WebXRBoundedReferenceSpace bounds transform
https://bugs.webkit.org/show_bug.cgi?id=224365
<rdar://problem/76754927>
Modified: trunk/Source/WebCore/Modules/webxr/WebXRSpace.cpp (278562 => 278563)
--- trunk/Source/WebCore/Modules/webxr/WebXRSpace.cpp 2021-06-07 15:37:54 UTC (rev 278562)
+++ trunk/Source/WebCore/Modules/webxr/WebXRSpace.cpp 2021-06-07 17:00:31 UTC (rev 278563)
@@ -50,7 +50,7 @@
{
// https://immersive-web.github.io/webxr/#xrspace-effective-origin
// The effective origin can be obtained by multiplying origin offset and the native origin.
- return m_originOffset->rawTransform() * nativeOrigin();
+ return nativeOrigin() * m_originOffset->rawTransform();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
