Title: [278763] trunk
- Revision
- 278763
- Author
- achristen...@apple.com
- Date
- 2021-06-11 09:15:18 -0700 (Fri, 11 Jun 2021)
Log Message
EventSource.constructor throws an exception when the url param is an empty string
https://bugs.webkit.org/show_bug.cgi?id=226635
Reviewed by Yusuke Suzuki.
Source/WebCore:
* page/EventSource.cpp:
(WebCore::EventSource::create):
LayoutTests:
* fast/eventsource/eventsource-constructor-expected.txt:
* fast/eventsource/eventsource-constructor.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (278762 => 278763)
--- trunk/LayoutTests/ChangeLog 2021-06-11 15:34:23 UTC (rev 278762)
+++ trunk/LayoutTests/ChangeLog 2021-06-11 16:15:18 UTC (rev 278763)
@@ -1,3 +1,13 @@
+2021-06-11 Alex Christensen <achristen...@webkit.org>
+
+ EventSource.constructor throws an exception when the url param is an empty string
+ https://bugs.webkit.org/show_bug.cgi?id=226635
+
+ Reviewed by Yusuke Suzuki.
+
+ * fast/eventsource/eventsource-constructor-expected.txt:
+ * fast/eventsource/eventsource-constructor.html:
+
2021-06-11 Diego Pino Garcia <dp...@igalia.com>
[GTK] Test css3/filters/composited-during-animation-layertree.html is flaky since r214292
Modified: trunk/LayoutTests/fast/eventsource/eventsource-constructor-expected.txt (278762 => 278763)
--- trunk/LayoutTests/fast/eventsource/eventsource-constructor-expected.txt 2021-06-11 15:34:23 UTC (rev 278762)
+++ trunk/LayoutTests/fast/eventsource/eventsource-constructor-expected.txt 2021-06-11 16:15:18 UTC (rev 278763)
@@ -1,7 +1,7 @@
Test EventSource constructor functionality. Should print a series of PASS messages followed by DONE.
PASS: missing argument to EventSource constructor resulted in an exception (TypeError: Not enough arguments)
-PASS: passing an empty string to the EventSource constructor resulted in an exception (SyntaxError: The string did not match the expected pattern.)
+PASS: no exception when passing an empty string to the EventSource constructor
PASS: passing an invalid URL to the EventSource constructor resulted in an exception (SyntaxError: The string did not match the expected pattern.)
PASS: no exception when passing a second argument to the EventSource constructor
DONE
Modified: trunk/LayoutTests/fast/eventsource/eventsource-constructor.html (278762 => 278763)
--- trunk/LayoutTests/fast/eventsource/eventsource-constructor.html 2021-06-11 15:34:23 UTC (rev 278762)
+++ trunk/LayoutTests/fast/eventsource/eventsource-constructor.html 2021-06-11 16:15:18 UTC (rev 278763)
@@ -22,10 +22,10 @@
try {
new EventSource("");
- log("FAIL: no exception when passing an empty string to the EventSource constructor");
+ log("PASS: no exception when passing an empty string to the EventSource constructor");
}
catch (ex) {
- log("PASS: passing an empty string to the EventSource constructor resulted in an exception (" + ex + ")");
+ log("FAIL: passing an empty string to the EventSource constructor resulted in an exception (" + ex + ")");
}
try {
Modified: trunk/Source/WebCore/ChangeLog (278762 => 278763)
--- trunk/Source/WebCore/ChangeLog 2021-06-11 15:34:23 UTC (rev 278762)
+++ trunk/Source/WebCore/ChangeLog 2021-06-11 16:15:18 UTC (rev 278763)
@@ -1,3 +1,13 @@
+2021-06-11 Alex Christensen <achristen...@webkit.org>
+
+ EventSource.constructor throws an exception when the url param is an empty string
+ https://bugs.webkit.org/show_bug.cgi?id=226635
+
+ Reviewed by Yusuke Suzuki.
+
+ * page/EventSource.cpp:
+ (WebCore::EventSource::create):
+
2021-06-11 Adrian Perez de Castro <ape...@igalia.com>
Unreviewed non-unified build fixes.
Modified: trunk/Source/WebCore/page/EventSource.cpp (278762 => 278763)
--- trunk/Source/WebCore/page/EventSource.cpp 2021-06-11 15:34:23 UTC (rev 278762)
+++ trunk/Source/WebCore/page/EventSource.cpp 2021-06-11 16:15:18 UTC (rev 278763)
@@ -66,9 +66,6 @@
ExceptionOr<Ref<EventSource>> EventSource::create(ScriptExecutionContext& context, const String& url, const Init& eventSourceInit)
{
- if (url.isEmpty())
- return Exception { SyntaxError };
-
URL fullURL = context.completeURL(url);
if (!fullURL.isValid())
return Exception { SyntaxError };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
