Title: [278854] trunk/Tools
Revision
278854
Author
keith_mil...@apple.com
Date
2021-06-14 17:54:08 -0700 (Mon, 14 Jun 2021)

Log Message

run-_javascript_core-tests should print output when a test binary fails by default
https://bugs.webkit.org/show_bug.cgi?id=226985

Reviewed by Mark Lam.

* Scripts/run-_javascript_core-tests:
(runTest):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (278853 => 278854)


--- trunk/Tools/ChangeLog	2021-06-15 00:46:19 UTC (rev 278853)
+++ trunk/Tools/ChangeLog	2021-06-15 00:54:08 UTC (rev 278854)
@@ -1,3 +1,13 @@
+2021-06-14  Keith Miller  <keith_mil...@apple.com>
+
+        run-_javascript_core-tests should print output when a test binary fails by default
+        https://bugs.webkit.org/show_bug.cgi?id=226985
+
+        Reviewed by Mark Lam.
+
+        * Scripts/run-_javascript_core-tests:
+        (runTest):
+
 2021-06-14  Ryan Haddad  <ryanhad...@apple.com>
 
         Bring up an Apple-BigSur-AppleSilicon-Release-Test262-Tests queue

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (278853 => 278854)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2021-06-15 00:46:19 UTC (rev 278853)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2021-06-15 00:54:08 UTC (rev 278854)
@@ -630,13 +630,16 @@
     my $lastOptimizeLevel;
 
     open(TEST, "-|", "@command 2>&1") or die "Failed to run @command";
+    my $testOutput = "";
     while ( my $line = <TEST> ) {
-        print $line if ($verbose);
+        $testOutput .= $line;
     }
     $testResult = close(TEST) ? 0 : $?;
     $reportData{$testName} = $testResult ? {actual => "FAIL"} : {actual => "PASS"};
 
     my $exitStatus = exitStatus($testResult);
+
+    print "$testOutput" if ($verbose or $testResult);
     print "$testName completed with rc=$testResult ($exitStatus)\n\n";
 
     if ($testResult) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to