Title: [279103] trunk/Source/WebCore
Revision
279103
Author
j...@apple.com
Date
2021-06-21 21:57:23 -0700 (Mon, 21 Jun 2021)

Log Message

Safari 15 breaks all Web Audio content using WebM Opus
https://bugs.webkit.org/show_bug.cgi?id=226922
rdar://79218243

Reviewed by Eric Carlson.

Temporarily reports that neither Opus and Vorbis audio codec are supported to allow
webaudio sites to fallback to other containers. The content will continue to play
as before. Will be reverted once bug 227110 lands.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType const):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (279102 => 279103)


--- trunk/Source/WebCore/ChangeLog	2021-06-22 04:21:54 UTC (rev 279102)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 04:57:23 UTC (rev 279103)
@@ -1,5 +1,20 @@
 2021-06-21  Jean-Yves Avenard  <j...@apple.com>
 
+        Safari 15 breaks all Web Audio content using WebM Opus
+        https://bugs.webkit.org/show_bug.cgi?id=226922
+        rdar://79218243
+
+        Reviewed by Eric Carlson.
+
+        Temporarily reports that neither Opus and Vorbis audio codec are supported to allow
+        webaudio sites to fallback to other containers. The content will continue to play
+        as before. Will be reverted once bug 227110 lands.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::canPlayType const):
+
+2021-06-21  Jean-Yves Avenard  <j...@apple.com>
+
         Merge AudioFileReaderMac and AudioFileReaderIOS into AudioFileReaderCocoa
         https://bugs.webkit.org/show_bug.cgi?id=227205
         <rdar://problem/79549527>

Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (279102 => 279103)


--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2021-06-22 04:21:54 UTC (rev 279102)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2021-06-22 04:57:23 UTC (rev 279103)
@@ -1045,6 +1045,14 @@
     MediaPlayer::SupportsType support = MediaPlayer::supportsType(parameters);
     String canPlay;
 
+#if PLATFORM(COCOA)
+    // Temporarily work around bug 226922. For now claim that the opus and vorbis codecs aren't supported
+    // so that sites relying on this test to determine if webaudio use of opus or vorbis won't error.
+    auto codecs = contentType.codecs();
+    if (support == MediaPlayer::SupportsType::IsSupported && (codecs.contains("opus") || codecs.contains("vorbis")))
+        support = MediaPlayer::SupportsType::IsNotSupported;
+#endif
+
     // 4.8.10.3
     switch (support)
     {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to