Title: [279388] trunk/Source/WebKit
- Revision
- 279388
- Author
- [email protected]
- Date
- 2021-06-29 14:51:33 -0700 (Tue, 29 Jun 2021)
Log Message
Don't null check destination in the RemoteRenderingBackend::nextDestinationImageBufferAfterApply main loop
https://bugs.webkit.org/show_bug.cgi?id=227475
Reviewed by Wenson Hsieh.
We already null check it and return early as part of the
MESSAGE_CHECK_WITH_RETURN_VALUE call just above.
* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::nextDestinationImageBufferAfterApplyingDisplayLists):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (279387 => 279388)
--- trunk/Source/WebKit/ChangeLog 2021-06-29 21:50:01 UTC (rev 279387)
+++ trunk/Source/WebKit/ChangeLog 2021-06-29 21:51:33 UTC (rev 279388)
@@ -1,3 +1,16 @@
+2021-06-29 Cameron McCormack <[email protected]>
+
+ Don't null check destination in the RemoteRenderingBackend::nextDestinationImageBufferAfterApply main loop
+ https://bugs.webkit.org/show_bug.cgi?id=227475
+
+ Reviewed by Wenson Hsieh.
+
+ We already null check it and return early as part of the
+ MESSAGE_CHECK_WITH_RETURN_VALUE call just above.
+
+ * GPUProcess/graphics/RemoteRenderingBackend.cpp:
+ (WebKit::RemoteRenderingBackend::nextDestinationImageBufferAfterApplyingDisplayLists):
+
2021-06-24 Jer Noble <[email protected]>
Loading WebM hangs if server sends only small amount of data
Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (279387 => 279388)
--- trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-06-29 21:50:01 UTC (rev 279387)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-06-29 21:51:33 UTC (rev 279388)
@@ -282,12 +282,6 @@
MESSAGE_CHECK_WITH_RETURN_VALUE(destination, nullptr, "Missing image buffer destination when resuming display list processing");
offset = resumeReadingInfo->offset;
-
- if (!destination) {
- ASSERT(!m_pendingWakeupInfo);
- m_pendingWakeupInfo = {{{ handle.identifier(), offset, newDestinationIdentifier, reason }, std::nullopt }};
- break;
- }
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
