Title: [279392] trunk/Source
- Revision
- 279392
- Author
- [email protected]
- Date
- 2021-06-29 15:50:17 -0700 (Tue, 29 Jun 2021)
Log Message
WebKit_iosmac build failure: SystemPreviewSPI.h:29:9: fatal error: 'AssetViewer/ARQuickLookWebKitItem.h' file not found
https://bugs.webkit.org/show_bug.cgi?id=227507
<rdar://problem/79902043>
Reviewed by Dean Jackson.
When we added new SPIs in Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h as part of r279312 we also included this file
from a new file that is compiled on Catalyst. This revealed an issue where existing SPIs included in that file weren't
actually available on Catalyst. We now make sure we compile those out on Catalyst.
Source/WebCore/PAL:
* pal/spi/ios/SystemPreviewSPI.h:
Source/WTF:
* wtf/PlatformHave.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (279391 => 279392)
--- trunk/Source/WTF/ChangeLog 2021-06-29 22:25:29 UTC (rev 279391)
+++ trunk/Source/WTF/ChangeLog 2021-06-29 22:50:17 UTC (rev 279392)
@@ -1,3 +1,17 @@
+2021-06-29 Antoine Quint <[email protected]>
+
+ WebKit_iosmac build failure: SystemPreviewSPI.h:29:9: fatal error: 'AssetViewer/ARQuickLookWebKitItem.h' file not found
+ https://bugs.webkit.org/show_bug.cgi?id=227507
+ <rdar://problem/79902043>
+
+ Reviewed by Dean Jackson.
+
+ When we added new SPIs in Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h as part of r279312 we also included this file
+ from a new file that is compiled on Catalyst. This revealed an issue where existing SPIs included in that file weren't
+ actually available on Catalyst. We now make sure we compile those out on Catalyst.
+
+ * wtf/PlatformHave.h:
+
2021-06-29 Antti Koivisto <[email protected]>
Enable Probabilistic Guard Malloc for RuleData and RuleFeature vectors
Modified: trunk/Source/WTF/wtf/PlatformHave.h (279391 => 279392)
--- trunk/Source/WTF/wtf/PlatformHave.h 2021-06-29 22:25:29 UTC (rev 279391)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2021-06-29 22:50:17 UTC (rev 279392)
@@ -489,7 +489,7 @@
#define HAVE_CTFONTCREATEFORCHARACTERSWITHLANGUAGEANDOPTION 1
#endif
-#if PLATFORM(IOS) || PLATFORM(MACCATALYST)
+#if PLATFORM(IOS)
#define HAVE_ARKIT_QUICK_LOOK_PREVIEW_ITEM 1
#endif
Modified: trunk/Source/WebCore/PAL/ChangeLog (279391 => 279392)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-06-29 22:25:29 UTC (rev 279391)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-06-29 22:50:17 UTC (rev 279392)
@@ -1,3 +1,17 @@
+2021-06-29 Antoine Quint <[email protected]>
+
+ WebKit_iosmac build failure: SystemPreviewSPI.h:29:9: fatal error: 'AssetViewer/ARQuickLookWebKitItem.h' file not found
+ https://bugs.webkit.org/show_bug.cgi?id=227507
+ <rdar://problem/79902043>
+
+ Reviewed by Dean Jackson.
+
+ When we added new SPIs in Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h as part of r279312 we also included this file
+ from a new file that is compiled on Catalyst. This revealed an issue where existing SPIs included in that file weren't
+ actually available on Catalyst. We now make sure we compile those out on Catalyst.
+
+ * pal/spi/ios/SystemPreviewSPI.h:
+
2021-06-24 Jer Noble <[email protected]>
Loading WebM hangs if server sends only small amount of data
Modified: trunk/Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h (279391 => 279392)
--- trunk/Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h 2021-06-29 22:25:29 UTC (rev 279391)
+++ trunk/Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h 2021-06-29 22:50:17 UTC (rev 279392)
@@ -29,7 +29,9 @@
#import <AssetViewer/ARQuickLookWebKitItem.h>
#endif
+#if PLATFORM(IOS)
#import <AssetViewer/ASVThumbnailView.h>
+#endif
#if HAVE(ARKIT_INLINE_PREVIEW_IOS)
#import <AssetViewer/ASVInlinePreview.h>
@@ -39,6 +41,7 @@
#import <UIKit/UIKit.h>
+#if PLATFORM(IOS)
@class ASVThumbnailView;
@class QLItem;
@class QLPreviewController;
@@ -52,6 +55,7 @@
@property (nonatomic, assign) QLItem *thumbnailItem;
@property (nonatomic) CGSize maxThumbnailSize;
@end
+#endif
#if HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
#import <ARKit/ARKit.h>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
