Title: [279457] trunk
Revision
279457
Author
emi...@crisal.io
Date
2021-07-01 02:03:38 -0700 (Thu, 01 Jul 2021)

Log Message

Support unprefixed :autofill pseudo-class.
https://bugs.webkit.org/show_bug.cgi?id=220459

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/selectors/pseudo-classes/autofill-expected.txt: Test passes now

Source/WebCore:

Tests: web-platform-tests/html/semantics/selectors/pseudo-classes/autofill.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:

LayoutTests:

* fast/css/css-selector-text-expected.txt:
* fast/css/css-selector-text.html:
* fast/css/css-set-selector-text-expected.txt:
* fast/css/css-set-selector-text.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (279456 => 279457)


--- trunk/LayoutTests/ChangeLog	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/LayoutTests/ChangeLog	2021-07-01 09:03:38 UTC (rev 279457)
@@ -1,3 +1,15 @@
+2021-07-01  Emilio Cobos Álvarez  <emi...@crisal.io>
+
+        Support unprefixed :autofill pseudo-class.
+        https://bugs.webkit.org/show_bug.cgi?id=220459
+
+        Reviewed by Antti Koivisto.
+
+        * fast/css/css-selector-text-expected.txt:
+        * fast/css/css-selector-text.html:
+        * fast/css/css-set-selector-text-expected.txt:
+        * fast/css/css-set-selector-text.html:
+
 2021-07-01  Tim Nguyen  <n...@apple.com>
 
         Merge LayoutTests/imported/blink/fast/dom/HTMLDialogElement and LayoutTests/imported/blink/dialog

Modified: trunk/LayoutTests/fast/css/css-selector-text-expected.txt (279456 => 279457)


--- trunk/LayoutTests/fast/css/css-selector-text-expected.txt	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/LayoutTests/fast/css/css-selector-text-expected.txt	2021-07-01 09:03:38 UTC (rev 279457)
@@ -82,8 +82,9 @@
 PASS parseThenSerializeRule('::selection { }') is '::selection { }'
 
 PASS parseThenSerializeRule(':-webkit-any-link { }') is ':-webkit-any-link { }'
-PASS parseThenSerializeRule(':-webkit-autofill { }') is ':-webkit-autofill { }'
 PASS parseThenSerializeRule(':-webkit-drag { }') is ':-webkit-drag { }'
+PASS parseThenSerializeRule(':autofill { }') is ':autofill { }'
+PASS parseThenSerializeRule(':-webkit-autofill { }') is ':autofill { }'
 
 PASS parseThenSerializeRule(':nth-child(odd) { }') is ':nth-child(2n+1) { }'
 PASS parseThenSerializeRule(':nth-child(even) { }') is ':nth-child(2n) { }'

Modified: trunk/LayoutTests/fast/css/css-selector-text.html (279456 => 279457)


--- trunk/LayoutTests/fast/css/css-selector-text.html	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/LayoutTests/fast/css/css-selector-text.html	2021-07-01 09:03:38 UTC (rev 279457)
@@ -154,8 +154,9 @@
 debug('');
 
 testSelectorRoundTrip(":-webkit-any-link");
-testSelectorRoundTrip(":-webkit-autofill");
 testSelectorRoundTrip(":-webkit-drag");
+testSelectorRoundTrip(":autofill");
+testSelectorSerialization(":-webkit-autofill", ":autofill");
 
 debug('');
 

Modified: trunk/LayoutTests/fast/css/css-set-selector-text-expected.txt (279456 => 279457)


--- trunk/LayoutTests/fast/css/css-set-selector-text-expected.txt	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/LayoutTests/fast/css/css-set-selector-text-expected.txt	2021-07-01 09:03:38 UTC (rev 279457)
@@ -77,8 +77,9 @@
 PASS setThenReadSelectorText('::selection') is '::selection'
 
 PASS setThenReadSelectorText(':-webkit-any-link') is ':-webkit-any-link'
-PASS setThenReadSelectorText(':-webkit-autofill') is ':-webkit-autofill'
 PASS setThenReadSelectorText(':-webkit-drag') is ':-webkit-drag'
+PASS setThenReadSelectorText(':autofill') is ':autofill'
+PASS setThenReadSelectorText(':-webkit-autofill') is ':autofill'
 PASS setThenReadSelectorText('a:any-link') is 'a:any-link'
 PASS setThenReadSelectorText('a :any-link') is 'a :any-link'
 PASS setThenReadSelectorText('div:any-link') is 'div:any-link'

Modified: trunk/LayoutTests/fast/css/css-set-selector-text.html (279456 => 279457)


--- trunk/LayoutTests/fast/css/css-set-selector-text.html	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/LayoutTests/fast/css/css-set-selector-text.html	2021-07-01 09:03:38 UTC (rev 279457)
@@ -150,8 +150,9 @@
 debug('');
 
 testSelectorRoundTrip(":-webkit-any-link");
-testSelectorRoundTrip(":-webkit-autofill");
 testSelectorRoundTrip(":-webkit-drag");
+testSelectorRoundTrip(":autofill");
+testSelectorSerialization(":-webkit-autofill", ":autofill");
 
 testSelectorRoundTrip('a:any-link');
 testSelectorRoundTrip('a :any-link');

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279456 => 279457)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-01 09:03:38 UTC (rev 279457)
@@ -1,3 +1,12 @@
+2021-07-01  Emilio Cobos Álvarez  <emi...@crisal.io>
+
+        Support unprefixed :autofill pseudo-class.
+        https://bugs.webkit.org/show_bug.cgi?id=220459
+
+        Reviewed by Antti Koivisto.
+
+        * web-platform-tests/html/semantics/selectors/pseudo-classes/autofill-expected.txt: Test passes now
+
 2021-06-30  Chris Dumez  <cdu...@apple.com>
 
         REGRESSION (r279427) [ Mac ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/integrity.html is failing

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/autofill-expected.txt (279456 => 279457)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/autofill-expected.txt	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/autofill-expected.txt	2021-07-01 09:03:38 UTC (rev 279457)
@@ -1,4 +1,4 @@
 
-FAIL ":autofill" should be a valid selector The string did not match the expected pattern.
+PASS ":autofill" should be a valid selector
 PASS ":-webkit-autofill" should be a valid selector
 

Modified: trunk/Source/WebCore/ChangeLog (279456 => 279457)


--- trunk/Source/WebCore/ChangeLog	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/Source/WebCore/ChangeLog	2021-07-01 09:03:38 UTC (rev 279457)
@@ -1,3 +1,16 @@
+2021-07-01  Emilio Cobos Álvarez  <emi...@crisal.io>
+
+        Support unprefixed :autofill pseudo-class.
+        https://bugs.webkit.org/show_bug.cgi?id=220459
+
+        Reviewed by Antti Koivisto.
+
+        Tests: web-platform-tests/html/semantics/selectors/pseudo-classes/autofill.html
+
+        * css/CSSSelector.cpp:
+        (WebCore::CSSSelector::selectorText const):
+        * css/SelectorPseudoClassAndCompatibilityElementMap.in:
+
 2021-07-01  Tim Nguyen  <n...@apple.com>
 
         Change `typedef EventSender<X> Y` to `using Y = EventSender<X>`

Modified: trunk/Source/WebCore/css/CSSSelector.cpp (279456 => 279457)


--- trunk/Source/WebCore/css/CSSSelector.cpp	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/Source/WebCore/css/CSSSelector.cpp	2021-07-01 09:03:38 UTC (rev 279457)
@@ -414,7 +414,7 @@
                 builder.append(":-webkit-any-link");
                 break;
             case CSSSelector::PseudoClassAutofill:
-                builder.append(":-webkit-autofill");
+                builder.append(":autofill");
                 break;
             case CSSSelector::PseudoClassAutofillStrongPassword:
                 builder.append(":-webkit-autofill-strong-password");

Modified: trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in (279456 => 279457)


--- trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in	2021-07-01 08:45:00 UTC (rev 279456)
+++ trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in	2021-07-01 09:03:38 UTC (rev 279457)
@@ -11,6 +11,7 @@
 active
 after, PseudoClassUnknown, PseudoElementAfter
 any-link
+autofill
 before, PseudoClassUnknown, PseudoElementBefore
 checked
 corner-present
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to