Title: [279499] trunk
- Revision
- 279499
- Author
- calva...@igalia.com
- Date
- 2021-07-02 00:01:19 -0700 (Fri, 02 Jul 2021)
Log Message
[GTK] media/event-attributes.html fails if mixer is not at 100%
https://bugs.webkit.org/show_bug.cgi?id=83704
Reviewed by Philippe Normand.
Tools:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): GStreamer
ports use fakesink to avoid sound output and setting the page
volume to 0 creates trouble with volume events. Let's avoid it in
GStreamer ports.
LayoutTests:
* platform/glib/TestExpectations: Unflagged that test and other
that get fixed with this patch.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (279498 => 279499)
--- trunk/LayoutTests/ChangeLog 2021-07-02 06:37:39 UTC (rev 279498)
+++ trunk/LayoutTests/ChangeLog 2021-07-02 07:01:19 UTC (rev 279499)
@@ -1,3 +1,13 @@
+2021-07-02 Xabier Rodriguez Calvar <calva...@igalia.com>
+
+ [GTK] media/event-attributes.html fails if mixer is not at 100%
+ https://bugs.webkit.org/show_bug.cgi?id=83704
+
+ Reviewed by Philippe Normand.
+
+ * platform/glib/TestExpectations: Unflagged that test and other
+ that get fixed with this patch.
+
2021-07-01 Jean-Yves Avenard <j...@apple.com>
[Cocoa] Last few seconds of 'audio/webm; codecs=vorbis' appended to a SampleBuffer are not played
Modified: trunk/LayoutTests/platform/glib/TestExpectations (279498 => 279499)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-07-02 06:37:39 UTC (rev 279498)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-07-02 07:01:19 UTC (rev 279499)
@@ -2182,7 +2182,6 @@
webkit.org/b/143702 media/progress-events-generated-correctly.html [ Failure ]
webkit.org/b/198830 media/context-menu-actions.html [ Pass Crash Failure ]
webkit.org/b/193638 media/video-webkit-playsinline.html [ Failure ]
-webkit.org/b/201266 media/audio-playback-restriction-play-muted.html [ Failure ]
webkit.org/b/224067 media/media-source/media-source-timestampoffset-trim.html [ Failure ]
webkit.org/b/160119 media/video-object-fit-change.html [ Pass Crash ImageOnlyFailure ]
@@ -2208,7 +2207,6 @@
webkit.org/b/145051 webkit.org/b/198830 [ Release ] media/video-rtl.html [ ImageOnlyFailure Pass Crash ]
webkit.org/b/145258 media/video-controller-child-rate.html [ Failure Pass ]
-webkit.org/b/158914 webkit.org/b/198830 media/restore-from-page-cache.html [ Failure ]
webkit.org/b/116277 media/video-buffered.html [ Pass Failure ]
webkit.org/b/186638 media/video-remote-control-playpause.html [ Failure Timeout Pass ]
@@ -2216,7 +2214,6 @@
webkit.org/b/198827 media/media-fullscreen-return-to-inline.html [ Timeout ]
-webkit.org/b/198830 media/event-attributes.html [ Crash Failure ]
webkit.org/b/198830 media/track/track-cue-css.html [ ImageOnlyFailure Failure Pass ]
webkit.org/b/198830 media/video-size-intrinsic-scale.html [ Failure ]
webkit.org/b/198830 http/tests/media/autoplay-if-audio-is-playing.html [ Pass Timeout ]
@@ -2231,16 +2228,10 @@
# GLX error in gst_gl_context_glx_create_context
webkit.org/b/210374 http/tests/media/user-gesture-preserved-across-xmlhttprequest.html [ Failure Pass Timeout ]
-webkit.org/b/208293 media/video-restricted-invisible-autoplay-allowed-if-audible.html [ Failure ]
-
http/tests/media/video-preload.html [ Pass Slow ]
webkit.org/b/108925 http/tests/media/video-play-stall.html [ Failure Timeout ]
-webkit.org/b/131545 media/media-event-listeners.html [ Timeout ]
-webkit.org/b/131545 media/video-volume.html [ Failure ]
-webkit.org/b/131545 media/audio-playback-volume-changes-with-restrictions.html [ Failure ]
-
webkit.org/b/135086 media/video-seek-with-negative-playback.html [ Timeout Pass ]
webkit.org/b/137698 media/video-controls-drag.html [ Timeout ]
webkit.org/b/141959 http/tests/media/clearkey/clear-key-hls-aes128.html [ Crash Timeout ]
Modified: trunk/Tools/ChangeLog (279498 => 279499)
--- trunk/Tools/ChangeLog 2021-07-02 06:37:39 UTC (rev 279498)
+++ trunk/Tools/ChangeLog 2021-07-02 07:01:19 UTC (rev 279499)
@@ -1,3 +1,16 @@
+2021-07-02 Xabier Rodriguez Calvar <calva...@igalia.com>
+
+ [GTK] media/event-attributes.html fails if mixer is not at 100%
+ https://bugs.webkit.org/show_bug.cgi?id=83704
+
+ Reviewed by Philippe Normand.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetStateToConsistentValues): GStreamer
+ ports use fakesink to avoid sound output and setting the page
+ volume to 0 creates trouble with volume events. Let's avoid it in
+ GStreamer ports.
+
2021-07-01 Jonathan Bedard <jbed...@apple.com>
[run-webkit-tests] Set software_variant from runtime
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (279498 => 279499)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2021-07-02 06:37:39 UTC (rev 279498)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2021-07-02 07:01:19 UTC (rev 279499)
@@ -984,7 +984,10 @@
WKPageClearWheelEventTestMonitor(m_mainWebView->page());
+ // GStreamer uses fakesink to avoid sound output during testing and doing this creates trouble with volume events.
+#if !USE(GSTREAMER)
WKPageSetMediaVolume(m_mainWebView->page(), 0);
+#endif
WKPageClearUserMediaState(m_mainWebView->page());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
