Title: [279820] trunk/Source/_javascript_Core
Revision
279820
Author
ysuz...@apple.com
Date
2021-07-12 00:53:37 -0700 (Mon, 12 Jul 2021)

Log Message

[JSC] JITCage already includes guard pages
https://bugs.webkit.org/show_bug.cgi?id=227867

Reviewed by Mark Lam.

Since JITCage already includes guard pages, we do not need to allocate that additionally.

* jit/ExecutableAllocator.cpp:
(JSC::initializeJITPageReservation):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279819 => 279820)


--- trunk/Source/_javascript_Core/ChangeLog	2021-07-12 07:40:05 UTC (rev 279819)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-12 07:53:37 UTC (rev 279820)
@@ -1,3 +1,15 @@
+2021-07-12  Yusuke Suzuki  <ysuz...@apple.com>
+
+        [JSC] JITCage already includes guard pages
+        https://bugs.webkit.org/show_bug.cgi?id=227867
+
+        Reviewed by Mark Lam.
+
+        Since JITCage already includes guard pages, we do not need to allocate that additionally.
+
+        * jit/ExecutableAllocator.cpp:
+        (JSC::initializeJITPageReservation):
+
 2021-07-10  Saam Barati  <sbar...@apple.com>
 
         Continue to consult InlineAccess's Structure even after switching to a stub IC

Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp (279819 => 279820)


--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp	2021-07-12 07:40:05 UTC (rev 279819)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp	2021-07-12 07:53:37 UTC (rev 279820)
@@ -356,7 +356,9 @@
         if (Options::logJITCodeForPerf())
             return PageReservation::reserveAndCommitWithGuardPages(reservationSize, OSAllocator::JSJITCodePages, EXECUTABLE_POOL_WRITABLE, true, false);
 #endif
-        return PageReservation::reserveWithGuardPages(reservationSize, OSAllocator::JSJITCodePages, EXECUTABLE_POOL_WRITABLE, true, Options::useJITCage());
+        if (Options::useJITCage())
+            return PageReservation::reserve(reservationSize, OSAllocator::JSJITCodePages, EXECUTABLE_POOL_WRITABLE, true, Options::useJITCage());
+        return PageReservation::reserveWithGuardPages(reservationSize, OSAllocator::JSJITCodePages, EXECUTABLE_POOL_WRITABLE, true, false);
     };
 
     reservation.pageReservation = tryCreatePageReservation(reservation.size);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to