Title: [279855] trunk/Source
- Revision
- 279855
- Author
- cfleiz...@apple.com
- Date
- 2021-07-12 16:07:14 -0700 (Mon, 12 Jul 2021)
Log Message
AX: Make WebKit observe spatial audio accessibility settings
https://bugs.webkit.org/show_bug.cgi?id=227848
Reviewed by Sam Weinig.
Source/WebKit:
Allow mac and iOS to read from accessibility domains.
Allow mac sandbox to read from com.apple.Accessibility.
* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
* UIProcess/Cocoa/PreferenceObserver.mm:
(-[WKPreferenceObserver init]):
Source/WTF:
This flag was using the wrong format for a HAVE setting, so the code wasn't being compiled in.
* wtf/PlatformHave.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (279854 => 279855)
--- trunk/Source/WTF/ChangeLog 2021-07-12 22:33:54 UTC (rev 279854)
+++ trunk/Source/WTF/ChangeLog 2021-07-12 23:07:14 UTC (rev 279855)
@@ -1,3 +1,14 @@
+2021-07-12 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: Make WebKit observe spatial audio accessibility settings
+ https://bugs.webkit.org/show_bug.cgi?id=227848
+
+ Reviewed by Sam Weinig.
+
+ This flag was using the wrong format for a HAVE setting, so the code wasn't being compiled in.
+
+ * wtf/PlatformHave.h:
+
2021-07-12 Simon Fraser <simon.fra...@apple.com>
Add a StyleSheets log channel and some logging
Modified: trunk/Source/WTF/wtf/PlatformHave.h (279854 => 279855)
--- trunk/Source/WTF/wtf/PlatformHave.h 2021-07-12 22:33:54 UTC (rev 279854)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2021-07-12 23:07:14 UTC (rev 279855)
@@ -1040,7 +1040,7 @@
#if (((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) \
|| (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000))
-#define UPDATE_WEB_ACCESSIBILITY_SETTINGS 1
+#define HAVE_UPDATE_WEB_ACCESSIBILITY_SETTINGS 1
#endif
#if PLATFORM(IOS) || PLATFORM(MACCATALYST)
Modified: trunk/Source/WebKit/ChangeLog (279854 => 279855)
--- trunk/Source/WebKit/ChangeLog 2021-07-12 22:33:54 UTC (rev 279854)
+++ trunk/Source/WebKit/ChangeLog 2021-07-12 23:07:14 UTC (rev 279855)
@@ -1,3 +1,17 @@
+2021-07-12 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: Make WebKit observe spatial audio accessibility settings
+ https://bugs.webkit.org/show_bug.cgi?id=227848
+
+ Reviewed by Sam Weinig.
+
+ Allow mac and iOS to read from accessibility domains.
+ Allow mac sandbox to read from com.apple.Accessibility.
+
+ * PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
+ * UIProcess/Cocoa/PreferenceObserver.mm:
+ (-[WKPreferenceObserver init]):
+
2021-07-12 Chris Dumez <cdu...@apple.com>
Unreviewed, reverting r279835.
Modified: trunk/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (279854 => 279855)
--- trunk/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2021-07-12 22:33:54 UTC (rev 279854)
+++ trunk/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2021-07-12 23:07:14 UTC (rev 279855)
@@ -261,6 +261,7 @@
(shared-preferences-read
".GlobalPreferences"
"com.apple.ATS"
+ "com.apple.Accessibility"
"com.apple.Bluetooth"
"com.apple.CoreGraphics"
"com.apple.HIToolbox"
Modified: trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm (279854 => 279855)
--- trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm 2021-07-12 22:33:54 UTC (rev 279854)
+++ trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm 2021-07-12 23:07:14 UTC (rev 279855)
@@ -129,8 +129,9 @@
return nil;
std::initializer_list<NSString*> domains = {
+ @"com.apple.Accessibility",
+ @"com.apple.mediaaccessibility",
#if PLATFORM(IOS_FAMILY)
- @"com.apple.Accessibility",
@"com.apple.AdLib",
@"com.apple.SpeakSelection",
@"com.apple.UIKit",
@@ -149,7 +150,6 @@
@"com.apple.avfoundation.videoperformancehud",
@"com.apple.driver.AppleBluetoothMultitouch.mouse",
@"com.apple.driver.AppleBluetoothMultitouch.trackpad",
- @"com.apple.mediaaccessibility",
@"com.apple.speech.voice.prefs",
@"com.apple.universalaccess",
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
