Title: [279876] trunk/Tools
- Revision
- 279876
- Author
- commit-qu...@webkit.org
- Date
- 2021-07-13 10:05:39 -0700 (Tue, 13 Jul 2021)
Log Message
[results.webkit.org] linkify urls in commit messages
https://bugs.webkit.org/show_bug.cgi?id=227549
<rdar://problem/79988762>
Patch by Kevin Neal <kevin_n...@apple.com> on 2021-07-13
Reviewed by Jonathan Bedard.
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:
(thead.tbody.rows.map.):
(thead.tbody.rows.map):
(CommitTable):
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (279875 => 279876)
--- trunk/Tools/ChangeLog 2021-07-13 16:46:18 UTC (rev 279875)
+++ trunk/Tools/ChangeLog 2021-07-13 17:05:39 UTC (rev 279876)
@@ -1,3 +1,18 @@
+2021-07-13 Kevin Neal <kevin_n...@apple.com>
+
+ [results.webkit.org] linkify urls in commit messages
+ https://bugs.webkit.org/show_bug.cgi?id=227549
+ <rdar://problem/79988762>
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:
+ (thead.tbody.rows.map.):
+ (thead.tbody.rows.map):
+ (CommitTable):
+ * Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js:
+
+
2021-07-13 Aakash Jain <aakash_j...@apple.com>
[build.webkit.org] Upload layout-tests results immediately after running layout-tests
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js (279875 => 279876)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js 2021-07-13 16:46:18 UTC (rev 279875)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js 2021-07-13 17:05:39 UTC (rev 279876)
@@ -21,7 +21,7 @@
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
// THE POSSIBILITY OF SUCH DAMAGE.
-import {ErrorDisplay, escapeHTML, paramsToQuery, queryToParams} from '/assets/js/common.js';
+import {ErrorDisplay, escapeHTML, linkify, paramsToQuery, queryToParams} from '/assets/js/common.js';
const TIMESTAMP_TO_UUID_MULTIPLIER = 100;
@@ -118,8 +118,8 @@
if (!cell.commit.message)
return '';
if (oneLine)
- return `<br><div>${escapeHTML(cell.commit.message.split('\n')[0])}</div>`;
- return `<br><div>${escapeHTML(cell.commit.message)}</div>`;
+ return `<br><div>${linkify(escapeHTML(cell.commit.message.split('\n')[0]))}</dv>`;
+ return `<br><div>${linkify(escapeHTML(cell.commit.message))}</div>`;
}()}
</td>`;
}).join('')}
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js (279875 => 279876)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js 2021-07-13 16:46:18 UTC (rev 279875)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js 2021-07-13 17:05:39 UTC (rev 279876)
@@ -139,6 +139,10 @@
});
}
+function linkify(text) {
+ return text.replace(/\b(https?|rdar):\/{2}[^\s<>&]+[^\.\s<>&,]/gmi, `<a href="" target="_blank">$&</a>`);
+}
+
function deepCompare(a, b) {
if (a === b)
return true;
@@ -193,4 +197,4 @@
return result;
}
-export {deepCompare, ErrorDisplay, queryToParams, paramsToQuery, QueryModifier, escapeHTML, percentage, elapsedTime};
+export {deepCompare, ErrorDisplay, queryToParams, paramsToQuery, QueryModifier, escapeHTML, linkify, percentage, elapsedTime};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
