Title: [279898] trunk/Tools
- Revision
- 279898
- Author
- jbed...@apple.com
- Date
- 2021-07-13 16:58:14 -0700 (Tue, 13 Jul 2021)
Log Message
[webkitscmpy] Handle failed `git log` process
https://bugs.webkit.org/show_bug.cgi?id=227709
<rdar://problem/80520002>
Rubber-stamped by Aakash Jain.
* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.Cache.populate): Do not populate cache if `git log` fails.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (279897 => 279898)
--- trunk/Tools/ChangeLog 2021-07-13 23:56:54 UTC (rev 279897)
+++ trunk/Tools/ChangeLog 2021-07-13 23:58:14 UTC (rev 279898)
@@ -1,3 +1,16 @@
+2021-07-13 Jonathan Bedard <jbed...@apple.com>
+
+ [webkitscmpy] Handle failed `git log` process
+ https://bugs.webkit.org/show_bug.cgi?id=227709
+ <rdar://problem/80520002>
+
+ Rubber-stamped by Aakash Jain.
+
+ * Scripts/libraries/webkitscmpy/setup.py: Bump version.
+ * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+ * Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
+ (Git.Cache.populate): Do not populate cache if `git log` fails.
+
2021-07-13 Alex Christensen <achristen...@webkit.org>
>4K Referer should have tailing /
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (279897 => 279898)
--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2021-07-13 23:56:54 UTC (rev 279897)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2021-07-13 23:58:14 UTC (rev 279898)
@@ -29,7 +29,7 @@
setup(
name='webkitscmpy',
- version='0.14.6',
+ version='0.14.7',
description='Library designed to interact with git and svn repositories.',
long_description=readme(),
classifiers=[
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (279897 => 279898)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2021-07-13 23:56:54 UTC (rev 279897)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2021-07-13 23:58:14 UTC (rev 279898)
@@ -46,7 +46,7 @@
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url <package index URL>`"
)
-version = Version(0, 14, 6)
+version = Version(0, 14, 7)
AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
AutoInstall.register(Package('monotonic', Version(1, 5)))
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py (279897 => 279898)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py 2021-07-13 23:56:54 UTC (rev 279897)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py 2021-07-13 23:58:14 UTC (rev 279898)
@@ -161,6 +161,9 @@
intersected = _append(branch, hash, revision=revision)
finally:
+ # If our `git log` operation failed, we can't count on the validity of our cache
+ if log and log.returncode:
+ return
if log:
log.kill()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
