Title: [279956] trunk/Source/WebCore
Revision
279956
Author
beid...@apple.com
Date
2021-07-15 13:12:14 -0700 (Thu, 15 Jul 2021)

Log Message

MemoryIDBBackingStore cleanup.
<rdar://79497380> and https://bugs.webkit.org/show_bug.cgi?id=227993

Reviewed by Geoffrey Garen.

* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::registerObjectStore):
* Modules/indexeddb/server/MemoryIDBBackingStore.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (279955 => 279956)


--- trunk/Source/WebCore/ChangeLog	2021-07-15 18:29:47 UTC (rev 279955)
+++ trunk/Source/WebCore/ChangeLog	2021-07-15 20:12:14 UTC (rev 279956)
@@ -1,3 +1,14 @@
+2021-07-15  Brady Eidson  <beid...@apple.com>
+
+        MemoryIDBBackingStore cleanup.
+        <rdar://79497380> and https://bugs.webkit.org/show_bug.cgi?id=227993
+
+        Reviewed by Geoffrey Garen.
+
+        * Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
+        (WebCore::IDBServer::MemoryIDBBackingStore::registerObjectStore):
+        * Modules/indexeddb/server/MemoryIDBBackingStore.h:
+
 2021-07-15  Tim Nguyen  <n...@apple.com>
 
         <dialog> element: do not perform close() method steps when removing open attribute.

Modified: trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp (279955 => 279956)


--- trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp	2021-07-15 18:29:47 UTC (rev 279955)
+++ trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp	2021-07-15 20:12:14 UTC (rev 279956)
@@ -585,8 +585,8 @@
 
 void MemoryIDBBackingStore::registerObjectStore(Ref<MemoryObjectStore>&& objectStore)
 {
-    ASSERT(!m_objectStoresByIdentifier.contains(objectStore->info().identifier()));
-    ASSERT(!m_objectStoresByName.contains(objectStore->info().name()));
+    RELEASE_ASSERT(!m_objectStoresByIdentifier.contains(objectStore->info().identifier()));
+    RELEASE_ASSERT(!m_objectStoresByName.contains(objectStore->info().name()));
 
     auto identifier = objectStore->info().identifier();
     m_objectStoresByName.set(objectStore->info().name(), &objectStore.get());

Modified: trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h (279955 => 279956)


--- trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h	2021-07-15 18:29:47 UTC (rev 279955)
+++ trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h	2021-07-15 20:12:14 UTC (rev 279956)
@@ -97,7 +97,7 @@
     HashMap<IDBResourceIdentifier, std::unique_ptr<MemoryBackingStoreTransaction>> m_transactions;
 
     HashMap<uint64_t, RefPtr<MemoryObjectStore>> m_objectStoresByIdentifier;
-    HashMap<String, MemoryObjectStore*> m_objectStoresByName;
+    HashMap<String, RefPtr<MemoryObjectStore>> m_objectStoresByName;
 };
 
 } // namespace IDBServer
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to