Title: [280426] trunk/LayoutTests
- Revision
- 280426
- Author
- cdu...@apple.com
- Date
- 2021-07-29 09:55:49 -0700 (Thu, 29 Jul 2021)
Log Message
storage/indexeddb/detached-iframe.html is flaky on some bots
https://bugs.webkit.org/show_bug.cgi?id=228569
<rdar://80396559>
Reviewed by Sihui Liu.
The test was flaky because the `detachIframe()` function was incorrect and actually
removing the iframe's parent instead of the iframe (Credit to Sihui for finding this
out). This patch fixes the issue and also adds a description() to improve the test
output.
* storage/indexeddb/detached-iframe-expected.txt:
* storage/indexeddb/detached-iframe.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (280425 => 280426)
--- trunk/LayoutTests/ChangeLog 2021-07-29 16:47:31 UTC (rev 280425)
+++ trunk/LayoutTests/ChangeLog 2021-07-29 16:55:49 UTC (rev 280426)
@@ -1,3 +1,19 @@
+2021-07-29 Chris Dumez <cdu...@apple.com>
+
+ storage/indexeddb/detached-iframe.html is flaky on some bots
+ https://bugs.webkit.org/show_bug.cgi?id=228569
+ <rdar://80396559>
+
+ Reviewed by Sihui Liu.
+
+ The test was flaky because the `detachIframe()` function was incorrect and actually
+ removing the iframe's parent instead of the iframe (Credit to Sihui for finding this
+ out). This patch fixes the issue and also adds a description() to improve the test
+ output.
+
+ * storage/indexeddb/detached-iframe-expected.txt:
+ * storage/indexeddb/detached-iframe.html:
+
2021-07-29 Myles C. Maxfield <mmaxfi...@apple.com>
☂️ [GPU Process] Defer removal of resources in the GPU Process until we've executed all display list items which reference them
Modified: trunk/LayoutTests/storage/indexeddb/detached-iframe-expected.txt (280425 => 280426)
--- trunk/LayoutTests/storage/indexeddb/detached-iframe-expected.txt 2021-07-29 16:47:31 UTC (rev 280425)
+++ trunk/LayoutTests/storage/indexeddb/detached-iframe-expected.txt 2021-07-29 16:55:49 UTC (rev 280426)
@@ -1,4 +1,13 @@
ALERT: original value
+IndexedDB edge case with a detached iframe.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/detached-iframe.html (280425 => 280426)
--- trunk/LayoutTests/storage/indexeddb/detached-iframe.html 2021-07-29 16:47:31 UTC (rev 280425)
+++ trunk/LayoutTests/storage/indexeddb/detached-iframe.html 2021-07-29 16:55:49 UTC (rev 280426)
@@ -2,14 +2,14 @@
<head>
<script src=""
<script src=""
+</head>
+<body>
<script>
+description("IndexedDB edge case with a detached iframe.");
function detachIframe() {
- var testIframe = document.getElementById('testIframe');
- testIframe.parentNode.remove(testIframe);
+ document.getElementById('testIframe').remove();
}
</script>
-</head>
-<body>
<script src=""
<iframe src="" id="testIframe"></iframe>
</body>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
