[webkit-changes] [280442] branches/safari-612.1.24.11-branch/Source/WebKit

Thu, 29 Jul 2021 13:15:59 -0700

Title: [280442] branches/safari-612.1.24.11-branch/Source/WebKit
Revision
280442
Author
alanc...@apple.com
Date
2021-07-29 13:15:11 -0700 (Thu, 29 Jul 2021)

Log Message

Cherry-pick r280424. rdar://problem/81286934

    [macOS Catalina] Some feature preferences have wrong default values
    https://bugs.webkit.org/show_bug.cgi?id=228564

    Reviewed by Tim Horton.

    When `HAVE(SYSTEM_FEATURE_FLAGS)` is false, we still need to enable
    some features by default.

    This patch makes sure the following features are enabled by default
    on macOS (consistent with the properties in WebKit-macos.plist):
    - async_frame_and_overflow_scrolling
    - gpu_process_canvas_rendering
    - gpu_process_media
    - gpu_process_webrtc
    - incremental_pdf
    - vp9_decoder
    - webm_format_reader
    - webm_parser

    * Shared/WebPreferencesDefaultValues.cpp:
    (WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
    (WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
    (WebKit::defaultUseGPUProcessForMediaEnabled):
    (WebKit::defaultCaptureAudioInGPUProcessEnabled):
    (WebKit::defaultCaptureVideoInGPUProcessEnabled):
    (WebKit::defaultWebRTCCodecsInGPUProcess):
    (WebKit::defaultIncrementalPDFEnabled):
    (WebKit::defaultWebMFormatReaderEnabled):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog (280441 => 280442)


--- branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog	2021-07-29 19:54:30 UTC (rev 280441)
+++ branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog	2021-07-29 20:15:11 UTC (rev 280442)
@@ -1,3 +1,70 @@
+2021-07-29  Alan Coon  <alanc...@apple.com>
+
+        Cherry-pick r280424. rdar://problem/81286934
+
+    [macOS Catalina] Some feature preferences have wrong default values
+    https://bugs.webkit.org/show_bug.cgi?id=228564
+    
+    Reviewed by Tim Horton.
+    
+    When `HAVE(SYSTEM_FEATURE_FLAGS)` is false, we still need to enable
+    some features by default.
+    
+    This patch makes sure the following features are enabled by default
+    on macOS (consistent with the properties in WebKit-macos.plist):
+    - async_frame_and_overflow_scrolling
+    - gpu_process_canvas_rendering
+    - gpu_process_media
+    - gpu_process_webrtc
+    - incremental_pdf
+    - vp9_decoder
+    - webm_format_reader
+    - webm_parser
+    
+    * Shared/WebPreferencesDefaultValues.cpp:
+    (WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
+    (WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
+    (WebKit::defaultUseGPUProcessForMediaEnabled):
+    (WebKit::defaultCaptureAudioInGPUProcessEnabled):
+    (WebKit::defaultCaptureVideoInGPUProcessEnabled):
+    (WebKit::defaultWebRTCCodecsInGPUProcess):
+    (WebKit::defaultIncrementalPDFEnabled):
+    (WebKit::defaultWebMFormatReaderEnabled):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-07-29  Peng Liu  <peng.l...@apple.com>
+
+            [macOS Catalina] Some feature preferences have wrong default values
+            https://bugs.webkit.org/show_bug.cgi?id=228564
+
+            Reviewed by Tim Horton.
+
+            When `HAVE(SYSTEM_FEATURE_FLAGS)` is false, we still need to enable
+            some features by default.
+
+            This patch makes sure the following features are enabled by default
+            on macOS (consistent with the properties in WebKit-macos.plist):
+            - async_frame_and_overflow_scrolling
+            - gpu_process_canvas_rendering
+            - gpu_process_media
+            - gpu_process_webrtc
+            - incremental_pdf
+            - vp9_decoder
+            - webm_format_reader
+            - webm_parser
+
+            * Shared/WebPreferencesDefaultValues.cpp:
+            (WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
+            (WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
+            (WebKit::defaultUseGPUProcessForMediaEnabled):
+            (WebKit::defaultCaptureAudioInGPUProcessEnabled):
+            (WebKit::defaultCaptureVideoInGPUProcessEnabled):
+            (WebKit::defaultWebRTCCodecsInGPUProcess):
+            (WebKit::defaultIncrementalPDFEnabled):
+            (WebKit::defaultWebMFormatReaderEnabled):
+
 2021-07-27  Alan Coon  <alanc...@apple.com>
 
         Cherry-pick r280351. rdar://problem/81196087

Modified: branches/safari-612.1.24.11-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (280441 => 280442)


--- branches/safari-612.1.24.11-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-07-29 19:54:30 UTC (rev 280441)
+++ branches/safari-612.1.24.11-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-07-29 20:15:11 UTC (rev 280442)
@@ -145,29 +145,41 @@
 
 bool defaultUseGPUProcessForCanvasRenderingEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_canvas_rendering");
+#else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
+    return false;
 #endif
-
-    return false;
 }
 
 bool defaultUseGPUProcessForDOMRenderingEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_dom_rendering");
+#else
+    return false;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
+    return false;
 #endif
-
-    return false;
 }
 
 bool defaultUseGPUProcessForMediaEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_media");
+#else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
+    return false;
 #endif
-
-    return false;
 }
 
 bool defaultUseGPUProcessForWebGLEnabled()
@@ -185,14 +197,21 @@
 
 bool defaultCaptureAudioInGPUProcessEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+
+#if HAVE(SYSTEM_FEATURE_FLAGS)
 #if PLATFORM(MAC)
     return isFeatureFlagEnabled("gpu_process_webrtc");
 #elif PLATFORM(IOS_FAMILY)
     return isFeatureFlagEnabled("gpu_process_media");
 #endif
+#else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+
+#else
+    return false;
 #endif
-    return false;
 }
 
 bool defaultCaptureAudioInUIProcessEnabled()
@@ -206,9 +225,13 @@
 
 bool defaultCaptureVideoInGPUProcessEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_webrtc");
 #else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
     return false;
 #endif
 }
@@ -219,9 +242,13 @@
 
 bool defaultWebRTCCodecsInGPUProcess()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_webrtc");
 #else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
     return false;
 #endif
 }
@@ -257,7 +284,11 @@
     return isFeatureFlagEnabled("incremental_pdf");
 #endif
 
+#if PLATFORM(MAC)
+    return true;
+#else
     return false;
+#endif
 }
 #endif
 
@@ -282,7 +313,11 @@
     return isFeatureFlagEnabled("webm_format_reader");
 #endif
 
+#if PLATFORM(MAC)
+    return true;
+#else
     return false;
+#endif
 }
 
 #endif // ENABLE(WEBM_FORMAT_READER)

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to