Diff
Modified: trunk/Source/WebKit/ChangeLog (280610 => 280611)
--- trunk/Source/WebKit/ChangeLog 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/ChangeLog 2021-08-03 20:36:45 UTC (rev 280611)
@@ -1,3 +1,42 @@
+2021-08-03 Tim Horton <timothy_hor...@apple.com>
+
+ Remove unused processDidTransitionTo{Foreground,Background} IPC
+ https://bugs.webkit.org/show_bug.cgi?id=228328
+
+ Reviewed by Wenson Hsieh.
+
+ * GPUProcess/GPUProcess.cpp:
+ (WebKit::GPUProcess::processDidTransitionToForeground): Deleted.
+ (WebKit::GPUProcess::processDidTransitionToBackground): Deleted.
+ * GPUProcess/GPUProcess.h:
+ * GPUProcess/GPUProcess.messages.in:
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::processDidTransitionToForeground): Deleted.
+ (WebKit::NetworkProcess::processDidTransitionToBackground): Deleted.
+ * NetworkProcess/NetworkProcess.h:
+ * NetworkProcess/NetworkProcess.messages.in:
+ * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+ (WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.
+ (WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.
+ * NetworkProcess/curl/NetworkProcessCurl.cpp:
+ (WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.
+ (WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.
+ * NetworkProcess/soup/NetworkProcessSoup.cpp:
+ (WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.
+ (WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.
+ * UIProcess/GPU/GPUProcessProxy.cpp:
+ (WebKit::GPUProcessProxy::updateProcessAssertion):
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::updateProcessAssertion):
+ * UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp:
+ (WebKit::WebAuthnProcessProxy::updateProcessAssertion):
+ * WebAuthnProcess/WebAuthnProcess.cpp:
+ (WebKit::WebAuthnProcess::processDidTransitionToForeground): Deleted.
+ (WebKit::WebAuthnProcess::processDidTransitionToBackground): Deleted.
+ * WebAuthnProcess/WebAuthnProcess.h:
+ * WebAuthnProcess/WebAuthnProcess.messages.in:
+ These messages do nothing.
+
2021-08-03 Per Arne <pvol...@apple.com>
[iOS] Fix sandbox violation in GPU process
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.cpp (280610 => 280611)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2021-08-03 20:36:45 UTC (rev 280611)
@@ -275,14 +275,6 @@
{
}
-void GPUProcess::processDidTransitionToForeground()
-{
-}
-
-void GPUProcess::processDidTransitionToBackground()
-{
-}
-
GPUConnectionToWebProcess* GPUProcess::webProcessConnection(ProcessIdentifier identifier) const
{
return m_webProcessConnections.get(identifier);
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.h (280610 => 280611)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.h 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.h 2021-08-03 20:36:45 UTC (rev 280611)
@@ -119,8 +119,6 @@
void addSession(PAL::SessionID, GPUProcessSessionParameters&&);
void removeSession(PAL::SessionID);
- void processDidTransitionToForeground();
- void processDidTransitionToBackground();
#if ENABLE(MEDIA_STREAM)
void setMockCaptureDevicesEnabled(bool);
void setOrientationForMediaCapture(uint64_t orientation);
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in (280610 => 280611)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in 2021-08-03 20:36:45 UTC (rev 280611)
@@ -27,9 +27,6 @@
CreateGPUConnectionToWebProcess(WebCore::ProcessIdentifier processIdentifier, PAL::SessionID sessionID, struct WebKit::GPUProcessConnectionParameters parameters) -> (std::optional<IPC::Attachment> connectionIdentifier) Async
- ProcessDidTransitionToForeground()
- ProcessDidTransitionToBackground()
-
PrepareToSuspend(bool isSuspensionImminent) -> () Async
ProcessDidResume()
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (280610 => 280611)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-08-03 20:36:45 UTC (rev 280611)
@@ -2196,16 +2196,6 @@
AuxiliaryProcess::terminate();
}
-void NetworkProcess::processDidTransitionToForeground()
-{
- platformProcessDidTransitionToForeground();
-}
-
-void NetworkProcess::processDidTransitionToBackground()
-{
- platformProcessDidTransitionToBackground();
-}
-
void NetworkProcess::processWillSuspendImminentlyForTestingSync(CompletionHandler<void()>&& completionHandler)
{
prepareToSuspend(true, WTFMove(completionHandler));
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (280610 => 280611)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2021-08-03 20:36:45 UTC (rev 280611)
@@ -398,11 +398,6 @@
void lowMemoryHandler(Critical);
- void processDidTransitionToForeground();
- void processDidTransitionToBackground();
- void platformProcessDidTransitionToForeground();
- void platformProcessDidTransitionToBackground();
-
// AuxiliaryProcess
void initializeProcess(const AuxiliaryProcessInitializationParameters&) override;
void initializeProcessName(const AuxiliaryProcessInitializationParameters&) override;
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in (280610 => 280611)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in 2021-08-03 20:36:45 UTC (rev 280611)
@@ -70,9 +70,6 @@
SetCacheModel(enum:uint8_t WebKit::CacheModel cacheModel)
SetCacheModelSynchronouslyForTesting(enum:uint8_t WebKit::CacheModel cacheModel) -> () Synchronous
- ProcessDidTransitionToBackground()
- ProcessDidTransitionToForeground()
-
ProcessWillSuspendImminentlyForTestingSync() -> () Synchronous
PrepareToSuspend(bool isSuspensionImminent) -> () Async
ProcessDidResume()
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (280610 => 280611)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2021-08-03 20:36:45 UTC (rev 280611)
@@ -243,12 +243,4 @@
completionHandler();
}
-void NetworkProcess::platformProcessDidTransitionToBackground()
-{
-}
-
-void NetworkProcess::platformProcessDidTransitionToForeground()
-{
-}
-
} // namespace WebKit
Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp (280610 => 280611)
--- trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2021-08-03 20:36:45 UTC (rev 280611)
@@ -55,16 +55,6 @@
notImplemented();
}
-void NetworkProcess::platformProcessDidTransitionToForeground()
-{
- notImplemented();
-}
-
-void NetworkProcess::platformProcessDidTransitionToBackground()
-{
- notImplemented();
-}
-
void NetworkProcess::setNetworkProxySettings(PAL::SessionID sessionID, WebCore::CurlProxySettings&& settings)
{
if (auto* networkStorageSession = storageSession(sessionID))
Modified: trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp (280610 => 280611)
--- trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp 2021-08-03 20:36:45 UTC (rev 280611)
@@ -171,14 +171,4 @@
static_cast<NetworkSessionSoup&>(*session).setPersistentCredentialStorageEnabled(enabled);
}
-void NetworkProcess::platformProcessDidTransitionToForeground()
-{
- notImplemented();
-}
-
-void NetworkProcess::platformProcessDidTransitionToBackground()
-{
- notImplemented();
-}
-
} // namespace WebKit
Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp (280610 => 280611)
--- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp 2021-08-03 20:36:45 UTC (rev 280611)
@@ -431,7 +431,6 @@
if (hasAnyForegroundWebProcesses) {
if (!ProcessThrottler::isValidForegroundActivity(m_activityFromWebProcesses)) {
m_activityFromWebProcesses = throttler().foregroundActivity("GPU for foreground view(s)"_s);
- send(Messages::GPUProcess::ProcessDidTransitionToForeground(), 0);
}
return;
}
@@ -438,7 +437,6 @@
if (hasAnyBackgroundWebProcesses) {
if (!ProcessThrottler::isValidBackgroundActivity(m_activityFromWebProcesses)) {
m_activityFromWebProcesses = throttler().backgroundActivity("GPU for background view(s)"_s);
- send(Messages::GPUProcess::ProcessDidTransitionToBackground(), 0);
}
return;
}
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (280610 => 280611)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-08-03 20:36:45 UTC (rev 280611)
@@ -1517,7 +1517,6 @@
if (anyProcessPoolHasForegroundWebProcesses()) {
if (!ProcessThrottler::isValidForegroundActivity(m_activityFromWebProcesses)) {
m_activityFromWebProcesses = throttler().foregroundActivity("Networking for foreground view(s)"_s);
- send(Messages::NetworkProcess::ProcessDidTransitionToForeground(), 0);
}
return;
}
@@ -1524,7 +1523,6 @@
if (anyProcessPoolHasBackgroundWebProcesses()) {
if (!ProcessThrottler::isValidBackgroundActivity(m_activityFromWebProcesses)) {
m_activityFromWebProcesses = throttler().backgroundActivity("Networking for background view(s)"_s);
- send(Messages::NetworkProcess::ProcessDidTransitionToBackground(), 0);
}
return;
}
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp (280610 => 280611)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp 2021-08-03 20:36:45 UTC (rev 280611)
@@ -168,7 +168,6 @@
if (hasAnyForegroundWebProcesses) {
if (!ProcessThrottler::isValidForegroundActivity(m_activityFromWebProcesses)) {
m_activityFromWebProcesses = throttler().foregroundActivity("WebAuthn for foreground view(s)"_s);
- send(Messages::WebAuthnProcess::ProcessDidTransitionToForeground(), 0);
}
return;
}
@@ -175,7 +174,6 @@
if (hasAnyBackgroundWebProcesses) {
if (!ProcessThrottler::isValidBackgroundActivity(m_activityFromWebProcesses)) {
m_activityFromWebProcesses = throttler().backgroundActivity("WebAuthn for background view(s)"_s);
- send(Messages::WebAuthnProcess::ProcessDidTransitionToBackground(), 0);
}
return;
}
Modified: trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.cpp (280610 => 280611)
--- trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.cpp 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.cpp 2021-08-03 20:36:45 UTC (rev 280611)
@@ -113,14 +113,6 @@
{
}
-void WebAuthnProcess::processDidTransitionToForeground()
-{
-}
-
-void WebAuthnProcess::processDidTransitionToBackground()
-{
-}
-
WebAuthnConnectionToWebProcess* WebAuthnProcess::webProcessConnection(ProcessIdentifier identifier) const
{
return m_webProcessConnections.get(identifier);
Modified: trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.h (280610 => 280611)
--- trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.h 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.h 2021-08-03 20:36:45 UTC (rev 280611)
@@ -82,9 +82,6 @@
void initializeWebAuthnProcess(WebAuthnProcessCreationParameters&&);
void createWebAuthnConnectionToWebProcess(WebCore::ProcessIdentifier, CompletionHandler<void(std::optional<IPC::Attachment>&&)>&&);
- void processDidTransitionToForeground();
- void processDidTransitionToBackground();
-
// Connections to WebProcesses.
HashMap<WebCore::ProcessIdentifier, Ref<WebAuthnConnectionToWebProcess>> m_webProcessConnections;
Modified: trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.messages.in (280610 => 280611)
--- trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.messages.in 2021-08-03 20:29:28 UTC (rev 280610)
+++ trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.messages.in 2021-08-03 20:36:45 UTC (rev 280611)
@@ -28,9 +28,6 @@
# Creates a connection for communication with a WebProcess
CreateWebAuthnConnectionToWebProcess(WebCore::ProcessIdentifier processIdentifier) -> (std::optional<IPC::Attachment> connectionIdentifier) Async
-
- ProcessDidTransitionToForeground()
- ProcessDidTransitionToBackground()
}
#endif // ENABLE(WEB_AUTHN)
