Title: [280655] trunk/Tools
- Revision
- 280655
- Author
- jbed...@apple.com
- Date
- 2021-08-04 13:44:38 -0700 (Wed, 04 Aug 2021)
Log Message
[check-github-mirror-integrity] Compare current time to canonical time
https://bugs.webkit.org/show_bug.cgi?id=228787
<rdar://problem/81524499>
Reviewed by Aakash Jain.
* Scripts/check-github-mirror-integrity: If the mirror isn't in line with the canonical repository, we should
check against the current time, not the time of last commit on the mirror.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (280654 => 280655)
--- trunk/Tools/ChangeLog 2021-08-04 20:28:16 UTC (rev 280654)
+++ trunk/Tools/ChangeLog 2021-08-04 20:44:38 UTC (rev 280655)
@@ -1,3 +1,14 @@
+2021-08-04 Jonathan Bedard <jbed...@apple.com>
+
+ [check-github-mirror-integrity] Compare current time to canonical time
+ https://bugs.webkit.org/show_bug.cgi?id=228787
+ <rdar://problem/81524499>
+
+ Reviewed by Aakash Jain.
+
+ * Scripts/check-github-mirror-integrity: If the mirror isn't in line with the canonical repository, we should
+ check against the current time, not the time of last commit on the mirror.
+
2021-08-03 Myles C. Maxfield <mmaxfi...@apple.com>
[Cocoa] Tweak the formatting for passing NSArrays to TextStreams
Modified: trunk/Tools/Scripts/check-github-mirror-integrity (280654 => 280655)
--- trunk/Tools/Scripts/check-github-mirror-integrity 2021-08-04 20:28:16 UTC (rev 280654)
+++ trunk/Tools/Scripts/check-github-mirror-integrity 2021-08-04 20:44:38 UTC (rev 280655)
@@ -24,6 +24,7 @@
import os
import sys
+import time
from webkitpy import webkitscmpy
from webkitscmpy import remote
@@ -41,7 +42,7 @@
print(f'HEAD commit on GitHub {mirror_tip} matches HEAD commit on svn.webkit.org {canonical_tip}')
return 0
- if mirror_tip.timestamp >= canonical_tip.timestamp - 5 * 60 and mirror_tip.identifier == canonical_tip.identifier - 1:
+ if time.time() >= canonical_tip.timestamp - 5 * 60 and mirror_tip.identifier == canonical_tip.identifier - 1:
print('GitHub is 1 commit behind svn.webkit.org. This is ok.')
print(f'HEAD commit on GitHub {mirror_tip} slightly behind HEAD commit on svn.webkit.org {canonical_tip}')
return 0
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
