Title: [280989] trunk/Source/WebInspectorUI
- Revision
- 280989
- Author
- pan...@apple.com
- Date
- 2021-08-12 15:50:45 -0700 (Thu, 12 Aug 2021)
Log Message
Web Inspector: Adding execution contexts after page load doesn't show a hidden execution selector
https://bugs.webkit.org/show_bug.cgi?id=229053
Reviewed by Devin Rousso.
Add a handler for execution contexts being added to update the display of the execution context list, as when
there is only a single context at page load the dropdown will be hidden and thus needs to be shown when an
execution context is added after page load.
* UserInterface/Views/QuickConsole.js:
(WI.QuickConsole):
(WI.QuickConsole.prototype._handleFrameExecutionContextAdded):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (280988 => 280989)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-08-12 22:27:09 UTC (rev 280988)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-08-12 22:50:45 UTC (rev 280989)
@@ -1,3 +1,18 @@
+2021-08-12 Patrick Angle <pan...@apple.com>
+
+ Web Inspector: Adding execution contexts after page load doesn't show a hidden execution selector
+ https://bugs.webkit.org/show_bug.cgi?id=229053
+
+ Reviewed by Devin Rousso.
+
+ Add a handler for execution contexts being added to update the display of the execution context list, as when
+ there is only a single context at page load the dropdown will be hidden and thus needs to be shown when an
+ execution context is added after page load.
+
+ * UserInterface/Views/QuickConsole.js:
+ (WI.QuickConsole):
+ (WI.QuickConsole.prototype._handleFrameExecutionContextAdded):
+
2021-08-12 Nikita Vasilyev <nvasil...@apple.com>
REGRESSION (r271348): Web Inspector: Table headers have vertical scrollbar
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js (280988 => 280989)
--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2021-08-12 22:27:09 UTC (rev 280988)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2021-08-12 22:50:45 UTC (rev 280989)
@@ -69,6 +69,7 @@
WI.Frame.addEventListener(WI.Frame.Event.PageExecutionContextChanged, this._handleFramePageExecutionContextChanged, this);
WI.Frame.addEventListener(WI.Frame.Event.ExecutionContextsCleared, this._handleFrameExecutionContextsCleared, this);
+ WI.Frame.addEventListener(WI.Frame.Event.ExecutionContextAdded, this._handleFrameExecutionContextAdded, this);
WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.ActiveCallFrameDidChange, this._handleDebuggerActiveCallFrameDidChange, this);
@@ -372,6 +373,11 @@
this._setActiveExecutionContext(frame.pageExecutionContext);
}
+ _handleFrameExecutionContextAdded(event)
+ {
+ this._updateActiveExecutionContextDisplay();
+ }
+
_handleFrameExecutionContextsCleared(event)
{
let {committingProvisionalLoad, contexts} = event.data;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
